diff mbox

Also define off_t in stdio.h for UNIX98

Message ID alpine.DEB.2.20.1604281526200.13527@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers April 28, 2016, 3:26 p.m. UTC 
Similar to my previous fix for XOPEN2K
<https://sourceware.org/ml/libc-alpha/2016-04/msg00631.html>, now that
bugs in the conformtest expectations for stdio.h for UNIX98 have been
corrected, that case too fails because fseeko and ftello are now
correctly expected, but off_t is not defined.  As in that fix, it
seems appropriate to define off_t in stdio.h for this standard as
well, and this patch does so.

Tested for x86_64 and x86 (testsuite, and that installed shared
libraries are unchanged by the patch).

2016-04-28  Joseph Myers  <joseph@codesourcery.com>

	* libio/stdio.h (off_t): Also define if [__USE_UNIX98].
	[__USE_LARGEFILE64] (off64_t): Likewise.
	* conform/Makefile (test-xfail-UNIX98/stdio.h/conform): Remove
	variable.

Comments

Paul Eggert April 28, 2016, 4:29 p.m. UTC | #1 
Thanks, this looks good too.
diff mbox

Patch

diff --git a/conform/Makefile b/conform/Makefile
index 26264fc..7665f77 100644
--- a/conform/Makefile
+++ b/conform/Makefile
@@ -202,7 +202,6 @@  test-xfail-UNIX98/langinfo.h/conform = yes
 test-xfail-UNIX98/netdb.h/conform = yes
 test-xfail-UNIX98/netinet/in.h/conform = yes
 test-xfail-UNIX98/signal.h/conform = yes
-test-xfail-UNIX98/stdio.h/conform = yes
 test-xfail-UNIX98/stdlib.h/conform = yes
 test-xfail-UNIX98/sys/time.h/conform = yes
 test-xfail-UNIX98/sys/wait.h/conform = yes
diff --git a/libio/stdio.h b/libio/stdio.h
index d7dbfad..712b994 100644
--- a/libio/stdio.h
+++ b/libio/stdio.h
@@ -84,7 +84,7 @@  typedef _G_va_list va_list;
 # endif
 #endif
 
-#ifdef __USE_XOPEN2K
+#if defined __USE_UNIX98 || defined __USE_XOPEN2K
 # ifndef __off_t_defined
 # ifndef __USE_FILE_OFFSET64
 typedef __off_t off_t;