| Message ID | 20081028212115.952319593@fr.ibm.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Daniel Lezcano <dlezcano@fr.ibm.com> Date: Tue, 28 Oct 2008 22:11:43 +0100 > The veth private structure contains a netdev pointer refering to its peer. > This field is never used and it is pointless because if we can access, > the veth_priv, that means we already have the netdev which is stored > in veth_priv->dev. > > Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: net-2.6/drivers/net/veth.c =================================================================== --- net-2.6.orig/drivers/net/veth.c +++ net-2.6/drivers/net/veth.c @@ -30,7 +30,6 @@ struct veth_net_stats { struct veth_priv { struct net_device *peer; - struct net_device *dev; struct list_head list; struct veth_net_stats *stats; unsigned ip_summed; @@ -420,12 +419,10 @@ static int veth_newlink(struct net_devic */ priv = netdev_priv(dev); - priv->dev = dev; priv->peer = peer; list_add(&priv->list, &veth_list); priv = netdev_priv(peer); - priv->dev = peer; priv->peer = dev; INIT_LIST_HEAD(&priv->list); return 0;
The veth private structure contains a netdev pointer refering to its peer. This field is never used and it is pointless because if we can access, the veth_priv, that means we already have the netdev which is stored in veth_priv->dev. Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com> --- drivers/net/veth.c | 3 --- 1 file changed, 3 deletions(-)