[tpmdd-devel] tpm: select ANON_INODES for proxy driver
diff mbox

Message ID 1461840382-2996256-1-git-send-email-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann April 28, 2016, 10:46 a.m. UTC
The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
is disabled:

drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
(.text+0x97f8): undefined reference to `anon_inode_getfile'

This adds a Kconfig 'select' statement to ensure it's always there
when we need it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Berger April 28, 2016, 10:52 a.m. UTC | #1
On 04/28/2016 06:46 AM, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
>
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
>
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")

Acked-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

Thanks.


------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
Jarkko Sakkinen April 29, 2016, 6:42 p.m. UTC | #2
On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
> 
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
> 
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")

Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> ---
>  drivers/char/tpm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 0eac596e33d1..bfdc5c0486aa 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -125,6 +125,7 @@ config TCG_CRB
>  config TCG_VTPM_PROXY
>  	tristate "VTPM Proxy Interface"
>  	depends on TCG_TPM
> +	select ANON_INODES
>  	---help---
>  	  This driver proxies for an emulated TPM (vTPM) running in userspace.
>  	  A device /dev/vtpmx is provided that creates a device pair
> -- 
> 2.7.0
> 

------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
Jarkko Sakkinen April 29, 2016, 7:41 p.m. UTC | #3
On Fri, Apr 29, 2016 at 09:42:06PM +0300, Jarkko Sakkinen wrote:
> On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> > The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> > is disabled:
> > 
> > drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> > (.text+0x97f8): undefined reference to `anon_inode_getfile'
> > 
> > This adds a Kconfig 'select' statement to ensure it's always there
> > when we need it.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
> 
> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> /Jarkko

Applied and merge to next.

/Jarkko

> > ---
> >  drivers/char/tpm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> > index 0eac596e33d1..bfdc5c0486aa 100644
> > --- a/drivers/char/tpm/Kconfig
> > +++ b/drivers/char/tpm/Kconfig
> > @@ -125,6 +125,7 @@ config TCG_CRB
> >  config TCG_VTPM_PROXY
> >  	tristate "VTPM Proxy Interface"
> >  	depends on TCG_TPM
> > +	select ANON_INODES
> >  	---help---
> >  	  This driver proxies for an emulated TPM (vTPM) running in userspace.
> >  	  A device /dev/vtpmx is provided that creates a device pair
> > -- 
> > 2.7.0
> > 

------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z

Patch
diff mbox

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 0eac596e33d1..bfdc5c0486aa 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -125,6 +125,7 @@  config TCG_CRB
 config TCG_VTPM_PROXY
 	tristate "VTPM Proxy Interface"
 	depends on TCG_TPM
+	select ANON_INODES
 	---help---
 	  This driver proxies for an emulated TPM (vTPM) running in userspace.
 	  A device /dev/vtpmx is provided that creates a device pair