diff mbox

[U-Boot] arm: dra7xx: Extend bootloader partition

Message ID 1461694617-13672-1-git-send-email-semen.protsenko@linaro.org
State Changes Requested
Delegated to: Tom Rini
Headers show

Commit Message

Sam Protsenko April 26, 2016, 6:16 p.m. UTC
With FIT images support enabled, u-boot.img size increases up to 612 KiB.
Extend "bootloader" partition size accordingly.

With extended "bootloader" partition there is no gap between "misc" and
"efs" partitions anymore. Keep "efs" partition alignment intact anyway
(start=1280K), so that Android partitions addresses  are compatible with
older versions of u-boot, while size of rest partitions can be adjusted.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 include/configs/dra7xx_evm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini April 27, 2016, 3:11 p.m. UTC | #1
On Tue, Apr 26, 2016 at 09:16:56PM +0300, Sam Protsenko wrote:

> With FIT images support enabled, u-boot.img size increases up to 612 KiB.
> Extend "bootloader" partition size accordingly.
> 
> With extended "bootloader" partition there is no gap between "misc" and
> "efs" partitions anymore. Keep "efs" partition alignment intact anyway
> (start=1280K), so that Android partitions addresses  are compatible with
> older versions of u-boot, while size of rest partitions can be adjusted.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

That's... really huge.  Is there something else that can perhaps come
out to allow that to fit in?  Can you share the rest of the config?  I'm
not seeing anything close to that by default here.  And I bring this up
because...

> ---
>  include/configs/dra7xx_evm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
> index 79b6c09..92373ac 100644
> --- a/include/configs/dra7xx_evm.h
> +++ b/include/configs/dra7xx_evm.h
> @@ -56,7 +56,7 @@
>  	"partitions_android=" \
>  	"uuid_disk=${uuid_gpt_disk};" \
>  	"name=xloader,start=128K,size=128K,uuid=${uuid_gpt_xloader};" \
> -	"name=bootloader,size=384K,uuid=${uuid_gpt_bootloader};" \
> +	"name=bootloader,size=768K,uuid=${uuid_gpt_bootloader};" \
>  	"name=environment,size=128K,uuid=${uuid_gpt_environment};" \
>  	"name=misc,size=128K,uuid=${uuid_gpt_misc};" \
>  	"name=efs,start=1280K,size=16M,uuid=${uuid_gpt_efs};" \

Given the problem with compatibility with other systems, I think we need
to have xloader-a and xloader-b, or to make the names still be
compatible:
	"uuid_disk=${uuid_gpt_disk};" \
	"name=xloader-b,start=128K,size=128K,uuid=${uuid_gpt_xloader};" \
	"name=xloader,start=128K,size=128K,uuid=${uuid_gpt_xloader};" \
	"name=bootloader,size=512K,uuid=${uuid_gpt_bootloader};" \

So that the first xloader is written to what the ROM considers the 3rd
try location.  If dra7xx won't actually try from that (I can't easily
test right this moment) then we need another misc inbetween xloader @
128KiB in and u-boot @ 386KiB in so that the U-Boot location is
compatible with the non-Android option.
Lokesh Vutla May 2, 2016, 5:21 a.m. UTC | #2
On Tuesday 26 April 2016 11:46 PM, Sam Protsenko wrote:
> With FIT images support enabled, u-boot.img size increases up to 612 KiB.
> Extend "bootloader" partition size accordingly.
> 
> With extended "bootloader" partition there is no gap between "misc" and
> "efs" partitions anymore. Keep "efs" partition alignment intact anyway
> (start=1280K), so that Android partitions addresses  are compatible with
> older versions of u-boot, while size of rest partitions can be adjusted.

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
>  include/configs/dra7xx_evm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
> index 79b6c09..92373ac 100644
> --- a/include/configs/dra7xx_evm.h
> +++ b/include/configs/dra7xx_evm.h
> @@ -56,7 +56,7 @@
>  	"partitions_android=" \
>  	"uuid_disk=${uuid_gpt_disk};" \
>  	"name=xloader,start=128K,size=128K,uuid=${uuid_gpt_xloader};" \
> -	"name=bootloader,size=384K,uuid=${uuid_gpt_bootloader};" \
> +	"name=bootloader,size=768K,uuid=${uuid_gpt_bootloader};" \
>  	"name=environment,size=128K,uuid=${uuid_gpt_environment};" \
>  	"name=misc,size=128K,uuid=${uuid_gpt_misc};" \
>  	"name=efs,start=1280K,size=16M,uuid=${uuid_gpt_efs};" \
>
diff mbox

Patch

diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
index 79b6c09..92373ac 100644
--- a/include/configs/dra7xx_evm.h
+++ b/include/configs/dra7xx_evm.h
@@ -56,7 +56,7 @@ 
 	"partitions_android=" \
 	"uuid_disk=${uuid_gpt_disk};" \
 	"name=xloader,start=128K,size=128K,uuid=${uuid_gpt_xloader};" \
-	"name=bootloader,size=384K,uuid=${uuid_gpt_bootloader};" \
+	"name=bootloader,size=768K,uuid=${uuid_gpt_bootloader};" \
 	"name=environment,size=128K,uuid=${uuid_gpt_environment};" \
 	"name=misc,size=128K,uuid=${uuid_gpt_misc};" \
 	"name=efs,start=1280K,size=16M,uuid=${uuid_gpt_efs};" \