Patchwork virtio-9p: Allow O_NOCTTY flag in open().

login
register
mail settings
Submitter Sripathi Kodi
Date Aug. 11, 2010, 1:53 p.m.
Message ID <20100811135358.16443.45490.stgit@sripathi.in.ibm.com>
Download mbox | patch
Permalink /patch/61483/
State New
Headers show

Comments

Sripathi Kodi - Aug. 11, 2010, 1:53 p.m.
Currently virtio-9p server doesn't allow O_NOCTTY flag in open().
However, gcc passes this flag while opening files. As a result it
is now impossible to compile any C code on the 9P mount!

I don't see any reason for dis-allowing O_NOCTTY flag in QEMU 9P server.
AFAIK QEMU starts off with a controlling terminal, so calling open with
O_NOCTTY flag is not going to make any difference to QEMU.

The following patch makes 9P server allow O_NOCTTY flag in open().

Signed-off-by: Sripathi Kodi <sripathik@in.ibm.com>
---

 hw/virtio-9p.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index 24115ef..f3b8bce 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -1676,11 +1676,11 @@  out:
 
 static inline int valid_flags(int flag)
 {
-    if (flag & O_NOCTTY || flag & O_NONBLOCK || flag & O_ASYNC ||
-            flag & O_CLOEXEC)
+    if (flag & O_NONBLOCK || flag & O_ASYNC || flag & O_CLOEXEC) {
         return 0;
-    else
+    } else {
         return 1;
+    }
 }
 
 static void v9fs_open_post_lstat(V9fsState *s, V9fsOpenState *vs, int err)