diff mbox

aeroflex/greth: fix warning about unused variable

Message ID 20160424175105.GA14620@ravnborg.org
State Accepted
Delegated to: David Miller
Headers show

Commit Message

Sam Ravnborg April 24, 2016, 5:51 p.m. UTC 
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 24 Apr 2016 18:39:52 +0200
Subject: [PATCH] aeroflex/greth: fix warning about unused variable

Fix following warning:
aeroflex/greth.c:1326:11: warning: unused variable 'phy' [-Wunused-variable]

The variable was unused - remove it.
It looks like this warning has been there forever - was found by an
allyesconfig build of sparc32.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Kristoffer Glembo <kristoffer@gaisler.com>
---
 drivers/net/ethernet/aeroflex/greth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sam Ravnborg April 24, 2016, 6:47 p.m. UTC | #1 
On Sun, Apr 24, 2016 at 07:51:05PM +0200, Sam Ravnborg wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun, 24 Apr 2016 18:39:52 +0200
> Subject: [PATCH] aeroflex/greth: fix warning about unused variable
> 
> Fix following warning:
> aeroflex/greth.c:1326:11: warning: unused variable 'phy' [-Wunused-variable]
> 
> The variable was unused - remove it.
> It looks like this warning has been there forever - was found by an
> allyesconfig build of sparc32.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Kristoffer Glembo <kristoffer@gaisler.com>

Kristoffer Glembo's mail bounces.
I have asked Gaisler for a replacement as maintainer.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller May 21, 2016, 1:34 a.m. UTC | #2 
From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 24 Apr 2016 19:51:05 +0200

> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun, 24 Apr 2016 18:39:52 +0200
> Subject: [PATCH] aeroflex/greth: fix warning about unused variable
> 
> Fix following warning:
> aeroflex/greth.c:1326:11: warning: unused variable 'phy' [-Wunused-variable]
> 
> The variable was unused - remove it.
> It looks like this warning has been there forever - was found by an
> allyesconfig build of sparc32.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/aeroflex/greth.c b/drivers/net/ethernet/aeroflex/greth.c
index b873531..bca07c5 100644
--- a/drivers/net/ethernet/aeroflex/greth.c
+++ b/drivers/net/ethernet/aeroflex/greth.c
@@ -1323,7 +1323,7 @@  static inline int phy_aneg_done(struct phy_device *phydev)
 
 static int greth_mdio_init(struct greth_private *greth)
 {
-	int ret, phy;
+	int ret;
 	unsigned long timeout;
 
 	greth->mdio = mdiobus_alloc();