| Message ID | 1461445189-31992-1-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Sat, 23 Apr 2016 22:59:48 +0200, Bernd Kuhls wrote: > diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk > index f25b9fa..ec52172 100644 > --- a/package/freeswitch/freeswitch.mk > +++ b/package/freeswitch/freeswitch.mk > @@ -153,6 +153,8 @@ define FREESWITCH_ENABLE_MODULES > $(Q)echo $(FREESWITCH_ENABLED_MODULES) \ > | tr ' ' '\n' \ > > $(@D)/modules.conf > + > $(@D)/noreg > + > $(@D)/cluecon2.tmpl Doesn't this deserve a separate pre-configure hook? Doing this hidden in the FREESWITCH_ENABLE_MODULES hook, with no comment or explanation whatsoever looks a bit weird. Thomas
Hello, On Sun, 24 Apr 2016 10:23:14 +0200, Thomas Petazzoni wrote: > Doesn't this deserve a separate pre-configure hook? Doing this hidden > in the FREESWITCH_ENABLE_MODULES hook, with no comment or explanation > whatsoever looks a bit weird. I've had no feedback, I'm marking this patch as Changes Requested in patchwork. Please resend with a separate hook, or a better explanation. Thanks! Thomas
diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk index f25b9fa..ec52172 100644 --- a/package/freeswitch/freeswitch.mk +++ b/package/freeswitch/freeswitch.mk @@ -153,6 +153,8 @@ define FREESWITCH_ENABLE_MODULES $(Q)echo $(FREESWITCH_ENABLED_MODULES) \ | tr ' ' '\n' \ > $(@D)/modules.conf + > $(@D)/noreg + > $(@D)/cluecon2.tmpl endef FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/freeswitch/freeswitch.mk | 2 ++ 1 file changed, 2 insertions(+)