diff mbox

[v1,2/4] msgpack: bump to version 1.4.0

Message ID 1461358628-9352-3-git-send-email-patrick.keroulas@savoirfairelinux.com
State Changes Requested
Headers show

Commit Message

Patrick Keroulas April 22, 2016, 8:57 p.m. UTC 
And install in staging dir.
---
 package/msgpack/msgpack.hash |  2 +-
 package/msgpack/msgpack.mk   | 10 ++++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

Comments

Thomas Petazzoni April 22, 2016, 9:23 p.m. UTC | #1 
Hello,

On Fri, 22 Apr 2016 16:57:06 -0400, Patrick Keroulas wrote:

> -MSGPACK_VERSION = 0.5.4
> -MSGPACK_SITE = http://downloads.sourceforge.net/project/msgpack/msgpack/cpp
> -MSGPACK_LICENSE = Apache-2.0
> -MSGPACK_LICENSE_FILES = COPYING
> +MSGPACK_VERSION = 1.4.0
> +MSGPACK_SOURCE = msgpack-$(MSGPACK_VERSION).tar.gz
> +MSGPACK_SITE = https://github.com/msgpack/msgpack-c/releases/download/cpp-$(MSGPACK_VERSION)
> +MSGPACK_LICENSE = Boost-1.0
> +MSGPACK_LICENSE_FILES = LICENSE_1_0.txt
> +MSGPACK_INSTALL_STAGING = YES

This seems like a major update. Did you check that the python-msgpack
package, which depends on msgpack, was still building/working fine
after this update?

Thanks!

Thomas
Thomas Petazzoni April 22, 2016, 9:52 p.m. UTC | #2 
Hello,

On Fri, 22 Apr 2016 16:57:06 -0400, Patrick Keroulas wrote:
> And install in staging dir.

Also missing your Signed-off-by line here.

Thanks!

Thomas
Patrick Keroulas May 2, 2016, 8:57 p.m. UTC | #3 
Hello

On Apr 22, 2016, at 5:23 PM, Thomas Petazzoni thomas.petazzoni@free-electrons.com wrote:
> On Fri, 22 Apr 2016 16:57:06 -0400, Patrick Keroulas wrote:
> 
>> -MSGPACK_VERSION = 0.5.4
>> -MSGPACK_SITE = http://downloads.sourceforge.net/project/msgpack/msgpack/cpp
>> -MSGPACK_LICENSE = Apache-2.0
>> -MSGPACK_LICENSE_FILES = COPYING
>> +MSGPACK_VERSION = 1.4.0
>> +MSGPACK_SOURCE = msgpack-$(MSGPACK_VERSION).tar.gz
>> +MSGPACK_SITE =
>> https://github.com/msgpack/msgpack-c/releases/download/cpp-$(MSGPACK_VERSION)
>> +MSGPACK_LICENSE = Boost-1.0
>> +MSGPACK_LICENSE_FILES = LICENSE_1_0.txt
>> +MSGPACK_INSTALL_STAGING = YES
> 
> This seems like a major update. Did you check that the python-msgpack
> package, which depends on msgpack, was still building/working fine
> after this update?

python-msgpack is still building correctly and I successfully used basic functionalities of this python module.
Is there anything else I should verify?
Thanks,

Patrick
diff mbox

Patch

diff --git a/package/msgpack/msgpack.hash b/package/msgpack/msgpack.hash
index 8cd8cb6..0b0d2d1 100644
--- a/package/msgpack/msgpack.hash
+++ b/package/msgpack/msgpack.hash
@@ -1,2 +1,2 @@ 
 # Locally computed:
-sha256  97a371ef950c89f48e8dba6abeccab07f1887e9ba6dab921de0f985c7d5075fe  msgpack-0.5.4.tar.gz
+sha256 2136f71560dc634492095aca5fc6d0fec30ce981b34b9777e03a366fbe3f550b msgpack-1.4.0.tar.gz
diff --git a/package/msgpack/msgpack.mk b/package/msgpack/msgpack.mk
index 9e23948..51aef2f 100644
--- a/package/msgpack/msgpack.mk
+++ b/package/msgpack/msgpack.mk
@@ -4,9 +4,11 @@ 
 #
 ################################################################################
 
-MSGPACK_VERSION = 0.5.4
-MSGPACK_SITE = http://downloads.sourceforge.net/project/msgpack/msgpack/cpp
-MSGPACK_LICENSE = Apache-2.0
-MSGPACK_LICENSE_FILES = COPYING
+MSGPACK_VERSION = 1.4.0
+MSGPACK_SOURCE = msgpack-$(MSGPACK_VERSION).tar.gz
+MSGPACK_SITE = https://github.com/msgpack/msgpack-c/releases/download/cpp-$(MSGPACK_VERSION)
+MSGPACK_LICENSE = Boost-1.0
+MSGPACK_LICENSE_FILES = LICENSE_1_0.txt
+MSGPACK_INSTALL_STAGING = YES
 
 $(eval $(autotools-package))