| Message ID | 20160422100638.4f4280bf@xeon-e3 |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 22 Apr 2016 10:06:38 -0700 > The file tc_ife.h was missing from the export list. > Rather than continue to cherry-pick, just export all headers in the directory. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Applied.
From: David Miller <davem@davemloft.net> Date: Mon, 25 Apr 2016 16:49:39 -0400 (EDT) > From: Stephen Hemminger <stephen@networkplumber.org> > Date: Fri, 22 Apr 2016 10:06:38 -0700 > >> The file tc_ife.h was missing from the export list. >> Rather than continue to cherry-pick, just export all headers in the directory. >> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > Applied. Please compile test, pretty please??!?!? ./usr/include/linux/tc_act/*.h: No such file or directory It looks like you can't expect shell expansions like that to work in Kbuild files.
On Mon, 25 Apr 2016 16:52:44 -0400 (EDT) David Miller <davem@davemloft.net> wrote: > From: David Miller <davem@davemloft.net> > Date: Mon, 25 Apr 2016 16:49:39 -0400 (EDT) > > > From: Stephen Hemminger <stephen@networkplumber.org> > > Date: Fri, 22 Apr 2016 10:06:38 -0700 > > > >> The file tc_ife.h was missing from the export list. > >> Rather than continue to cherry-pick, just export all headers in the directory. > >> > >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > > > Applied. > > Please compile test, pretty please??!?!? > > ./usr/include/linux/tc_act/*.h: No such file or directory > > It looks like you can't expect shell expansions like that to work in > Kbuild files. It worked for me but was testing the export function, not the build.
--- a/include/uapi/linux/tc_act/Kbuild 2015-05-21 15:13:05.121132983 -0700 +++ b/include/uapi/linux/tc_act/Kbuild 2016-04-22 10:03:24.733449078 -0700 @@ -1,12 +1,2 @@ # UAPI Header export list -header-y += tc_csum.h -header-y += tc_defact.h -header-y += tc_gact.h -header-y += tc_ipt.h -header-y += tc_mirred.h -header-y += tc_nat.h -header-y += tc_pedit.h -header-y += tc_skbedit.h -header-y += tc_vlan.h -header-y += tc_bpf.h -header-y += tc_connmark.h +header-y += *.h
The file tc_ife.h was missing from the export list. Rather than continue to cherry-pick, just export all headers in the directory. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>