Patchwork testsuite: support board_info timeouts

login
register
mail settings
Submitter DJ Delorie
Date Aug. 10, 2010, 3:48 a.m.
Message ID <201008100348.o7A3mVG7009468@greed.delorie.com>
Download mbox | patch
Permalink /patch/61332/
State New
Headers show

Comments

DJ Delorie - Aug. 10, 2010, 3:48 a.m.
Is there any reason why we don't support board-level timeouts?  It's
really hard to specify timeouts for sid-based embedded targets with
lots of multilibs (or just one, sometimes).

It's certainly better than "really REALLY ugly" which is the only
other option at that point.

	* lib/timeout.exp (timeout): Add board_info support.
 
 2010-08-09  Thomas Koenig  <tkoenig@gcc.gnu.org>
Mike Stump - Aug. 10, 2010, 4:08 a.m.
n Aug 9, 2010, at 8:48 PM, DJ Delorie wrote:
> Is there any reason why we don't support board-level timeouts?

I don't know of any...  If it helps you, I'd say, lets put it in...
DJ Delorie - June 2, 2011, 4:48 p.m.
I never got feedback from the testsuite maintainers on this one...

> Date: Mon, 9 Aug 2010 23:48:31 -0400
> From: DJ Delorie <dj@redhat.com>
> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
> 
> 
> Is there any reason why we don't support board-level timeouts?  It's
> really hard to specify timeouts for sid-based embedded targets with
> lots of multilibs (or just one, sometimes).
> 
> It's certainly better than "really REALLY ugly" which is the only
> other option at that point.
> 
> 	* lib/timeout.exp (timeout): Add board_info support.
>  
>  2010-08-09  Thomas Koenig  <tkoenig@gcc.gnu.org>
> Index: lib/timeout.exp
> ===================================================================
> --- lib/timeout.exp	(revision 163048)
> +++ lib/timeout.exp	(working copy)
> @@ -43,12 +43,14 @@ proc timeout_value { args } {
>      if [info exists individual_timeout] {
>  	set val $individual_timeout
>      } elseif [info exists tool_timeout] {
>  	set val $tool_timeout
>      } elseif [target_info exists gcc,timeout] {
>  	set val [target_info gcc,timeout]
> +    } elseif [board_info target exists gcc,timeout] {
> +	set val [board_info target gcc,timeout]
>      } else {
>  	# This is really, REALLY ugly, but this is the default from
>  	# remote.exp deep within DejaGnu.
>  	set val 300
>      }
>  
>
Mike Stump - June 2, 2011, 5:28 p.m.
On Jun 2, 2011, at 9:48 AM, DJ Delorie wrote:
> I never got feedback from the testsuite maintainers on this one...

Ok.
DJ Delorie - June 2, 2011, 6:16 p.m.
Thanks!  Committed.

Patch

Index: lib/timeout.exp
===================================================================
--- lib/timeout.exp	(revision 163048)
+++ lib/timeout.exp	(working copy)
@@ -43,12 +43,14 @@  proc timeout_value { args } {
     if [info exists individual_timeout] {
 	set val $individual_timeout
     } elseif [info exists tool_timeout] {
 	set val $tool_timeout
     } elseif [target_info exists gcc,timeout] {
 	set val [target_info gcc,timeout]
+    } elseif [board_info target exists gcc,timeout] {
+	set val [board_info target gcc,timeout]
     } else {
 	# This is really, REALLY ugly, but this is the default from
 	# remote.exp deep within DejaGnu.
 	set val 300
     }