diff mbox

[U-Boot,PATCHv2] cmd: Kconfig: Add a Kconfig options for a few CMD

Message ID 1461247523-22729-1-git-send-email-dinguyen@kernel.org
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Dinh Nguyen April 21, 2016, 2:05 p.m. UTC
Add the following CMD options to Kconfig:

CMD_BOOTZ
CMD_ASKENV
CMD_GREPENV
CMD_USB_MASS_STORAGE
CMD_FAT
CMD_MII
CMD_CACHE
CMD_DFU
CMD_EXT2
CMD_EXT4
CMD_EXT4_WRITE
CMD_FS_GENERIC
CMD_MMC

Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
v2: remove an extra CMD_DFU
---
 cmd/Kconfig | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

Comments

Simon Glass April 21, 2016, 2:13 p.m. UTC | #1
Hi Dinh,

On 21 April 2016 at 08:05, Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> Add the following CMD options to Kconfig:
>
> CMD_BOOTZ
> CMD_ASKENV
> CMD_GREPENV
> CMD_USB_MASS_STORAGE
> CMD_FAT
> CMD_MII
> CMD_CACHE
> CMD_DFU
> CMD_EXT2
> CMD_EXT4
> CMD_EXT4_WRITE
> CMD_FS_GENERIC
> CMD_MMC
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> v2: remove an extra CMD_DFU
> ---
>  cmd/Kconfig | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)

Can you convert existing users with moveconfig.py?

Regards,
Simon
Dinh Nguyen April 21, 2016, 2:18 p.m. UTC | #2
Hi Simon,

On 04/21/2016 09:13 AM, Simon Glass wrote:
> Hi Dinh,
> 
> On 21 April 2016 at 08:05, Dinh Nguyen <dinguyen@kernel.org> wrote:
>>
>> Add the following CMD options to Kconfig:
>>
>> CMD_BOOTZ
>> CMD_ASKENV
>> CMD_GREPENV
>> CMD_USB_MASS_STORAGE
>> CMD_FAT
>> CMD_MII
>> CMD_CACHE
>> CMD_DFU
>> CMD_EXT2
>> CMD_EXT4
>> CMD_EXT4_WRITE
>> CMD_FS_GENERIC
>> CMD_MMC
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> v2: remove an extra CMD_DFU
>> ---
>>  cmd/Kconfig | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 72 insertions(+)
> 
> Can you convert existing users with moveconfig.py?
> 

Yes, I started doing the moveconfig, starting with ARM, but I saw Tom's
message to hold off because it might conflict with his work. I'll be
happy to do the moveconfig, when I get Tom's OK to move ahead.

Dinh
Tom Rini April 21, 2016, 3:02 p.m. UTC | #3
On Thu, Apr 21, 2016 at 09:18:59AM -0500, Dinh Nguyen wrote:
> Hi Simon,
> 
> On 04/21/2016 09:13 AM, Simon Glass wrote:
> > Hi Dinh,
> > 
> > On 21 April 2016 at 08:05, Dinh Nguyen <dinguyen@kernel.org> wrote:
> >>
> >> Add the following CMD options to Kconfig:
> >>
> >> CMD_BOOTZ
> >> CMD_ASKENV
> >> CMD_GREPENV
> >> CMD_USB_MASS_STORAGE
> >> CMD_FAT
> >> CMD_MII
> >> CMD_CACHE
> >> CMD_DFU
> >> CMD_EXT2
> >> CMD_EXT4
> >> CMD_EXT4_WRITE
> >> CMD_FS_GENERIC
> >> CMD_MMC
> >>
> >> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> >> ---
> >> v2: remove an extra CMD_DFU
> >> ---
> >>  cmd/Kconfig | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 72 insertions(+)
> > 
> > Can you convert existing users with moveconfig.py?
> > 
> 
> Yes, I started doing the moveconfig, starting with ARM, but I saw Tom's
> message to hold off because it might conflict with his work. I'll be
> happy to do the moveconfig, when I get Tom's OK to move ahead.

The problem with doing moveconfig.py is that it does get conflict happy
so easily.  My intention with this patch at least is to set things up
locally so I can do that and test it here, then push, to make life a bit
easier.
Tom Rini April 22, 2016, 9:02 p.m. UTC | #4
On Thu, Apr 21, 2016 at 09:18:59AM -0500, Dinh Nguyen wrote:
> Hi Simon,
> 
> On 04/21/2016 09:13 AM, Simon Glass wrote:
> > Hi Dinh,
> > 
> > On 21 April 2016 at 08:05, Dinh Nguyen <dinguyen@kernel.org> wrote:
> >>
> >> Add the following CMD options to Kconfig:
> >>
> >> CMD_BOOTZ
> >> CMD_ASKENV
> >> CMD_GREPENV
> >> CMD_USB_MASS_STORAGE
> >> CMD_FAT
> >> CMD_MII
> >> CMD_CACHE
> >> CMD_DFU
> >> CMD_EXT2
> >> CMD_EXT4
> >> CMD_EXT4_WRITE
> >> CMD_FS_GENERIC
> >> CMD_MMC
> >>
> >> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> >> ---
> >> v2: remove an extra CMD_DFU
> >> ---
> >>  cmd/Kconfig | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 72 insertions(+)
> > 
> > Can you convert existing users with moveconfig.py?
> > 
> 
> Yes, I started doing the moveconfig, starting with ARM, but I saw Tom's
> message to hold off because it might conflict with his work. I'll be
> happy to do the moveconfig, when I get Tom's OK to move ahead.

I am making progress on this front but there's much that had not already
been converted, so I'm taking care of that first.
Tom Rini April 26, 2016, 12:17 a.m. UTC | #5
On Thu, Apr 21, 2016 at 09:05:23AM -0500, Dinh Nguyen wrote:

> Add the following CMD options to Kconfig:
> 
> CMD_BOOTZ
> CMD_ASKENV
> CMD_GREPENV
> CMD_USB_MASS_STORAGE
> CMD_FAT
> CMD_MII
> CMD_CACHE
> CMD_DFU
> CMD_EXT2
> CMD_EXT4
> CMD_EXT4_WRITE
> CMD_FS_GENERIC
> CMD_MMC
> 
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index fe8b4f0..ec7c054 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -160,6 +160,11 @@  config CMD_BOOTM
 	help
 	  Boot an application image from the memory.
 
+config CMD_BOOTZ
+	bool "bootz"
+	help
+	  Boot the Linux zImage
+
 config CMD_BOOTEFI
 	bool "bootefi"
 	depends on EFI_LOADER
@@ -210,6 +215,11 @@  endmenu
 
 menu "Environment commands"
 
+config CMD_ASKENV
+	bool "ask for env variable"
+	help
+	  Ask for environment variable
+
 config CMD_EXPORTENV
 	bool "env export"
 	default y
@@ -228,6 +238,11 @@  config CMD_EDITENV
 	help
 	  Edit environment variable.
 
+config CMD_GREPENV
+	bool "search env"
+	help
+	  Allow for searching environment variables
+
 config CMD_SAVEENV
 	bool "saveenv"
 	default y
@@ -341,6 +356,11 @@  config CMD_ARMFLASH
 	help
 	  ARM Ltd reference designs flash partition access
 
+config CMD_MMC
+	bool "mmc"
+	help
+	  MMC memory mapped support.
+
 config CMD_NAND
 	bool "nand"
 	help
@@ -366,6 +386,19 @@  config CMD_USB
 	help
 	  USB support.
 
+config CMD_DFU
+	depends on CMD_USB
+	bool "dfu"
+	help
+	  Enables the command "dfu" which is used to have U-Boot create a DFU
+	  class device via USB.
+
+config CMD_USB_MASS_STORAGE
+	depends on CMD_USB
+	bool "UMS usb mass storage"
+	help
+	  USB mass storage support
+
 config CMD_FPGA
 	bool "fpga"
 	default y
@@ -454,6 +487,11 @@  config CMD_NFS
 	help
 	  Boot image via network using NFS protocol.
 
+config CMD_MII
+	bool "mii"
+	help
+	  Enable MII utility commands.
+
 config CMD_PING
 	bool "ping"
 	help
@@ -508,6 +546,11 @@  config CMD_BLOCK_CACHE
 	  during development, but also allows the cache to be disabled when
 	  it might hurt performance (e.g. when using the ums command).
 
+config CMD_CACHE
+	bool "icache or dcache"
+	help
+	  Enable the "icache" and "dcache" commands
+
 config CMD_TIME
 	bool "time"
 	help
@@ -612,4 +655,33 @@  config CMD_TPM_TEST
 
 endmenu
 
+menu "Filesystem commands"
+config CMD_EXT2
+	bool "ext2 command support"
+	help
+	  Enables EXT2 FS command
+
+config CMD_EXT4
+	bool "ext4 command support"
+	help
+	  Enables EXT4 FS command
+
+config CMD_EXT4_WRITE
+	depends on CMD_EXT4
+	bool "ext4 write command support"
+	help
+	  Enables EXT4 FS write command
+
+config CMD_FAT
+	bool "FAT command support"
+	help
+	  Support for the FAT fs
+
+config CMD_FS_GENERIC
+	bool "filesystem commands"
+	help
+	  Enables filesystem commands (e.g. load, ls) that work for multiple
+	  fs types.
+endmenu
+
 endmenu