| Message ID | 4C604C62.7060509@austin.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Monday, August 09, 2010 11:43:46 am Nathan Fontenot wrote: > Update the memory hotplug documentation to reflect the new behaviors of > memory blocks reflected in sysfs. <snip> > Index: linux-2.6/Documentation/memory-hotplug.txt > =================================================================== > --- linux-2.6.orig/Documentation/memory-hotplug.txt 2010-08-09 07:36:48.000000000 -0500 > +++ linux-2.6/Documentation/memory-hotplug.txt 2010-08-09 07:59:54.000000000 -0500 <snip> > -/sys/devices/system/memory/memoryXXX/phys_index > +/sys/devices/system/memory/memoryXXX/start_phys_index > +/sys/devices/system/memory/memoryXXX/end_phys_index > /sys/devices/system/memory/memoryXXX/phys_device > /sys/devices/system/memory/memoryXXX/state > /sys/devices/system/memory/memoryXXX/removable > > -'phys_index' : read-only and contains section id, same as XXX. <snip> > +'phys_index' : read-only and contains section id of the first section Shouldn't this be "start_phys_index"? Thanks, Nish
On Monday, August 09, 2010 01:44:37 pm Nishanth Aravamudan wrote: > On Monday, August 09, 2010 11:43:46 am Nathan Fontenot wrote: > > Update the memory hotplug documentation to reflect the new behaviors of > > memory blocks reflected in sysfs. > > <snip> > > > Index: linux-2.6/Documentation/memory-hotplug.txt > > =================================================================== > > --- linux-2.6.orig/Documentation/memory-hotplug.txt 2010-08-09 07:36:48.000000000 -0500 > > +++ linux-2.6/Documentation/memory-hotplug.txt 2010-08-09 07:59:54.000000000 -0500 > > <snip> > > > -/sys/devices/system/memory/memoryXXX/phys_index > > +/sys/devices/system/memory/memoryXXX/start_phys_index > > +/sys/devices/system/memory/memoryXXX/end_phys_index > > /sys/devices/system/memory/memoryXXX/phys_device > > /sys/devices/system/memory/memoryXXX/state > > /sys/devices/system/memory/memoryXXX/removable > > > > -'phys_index' : read-only and contains section id, same as XXX. > > <snip> > > > +'phys_index' : read-only and contains section id of the first section > > Shouldn't this be "start_phys_index"? Ah, actually it's that the Documentation change doesn't seem to agree with patch 2/8 ? That is, 2/8 leaves phys_index in place, but changes several variables, while this patch indicates its removal? Thanks, Nish
On 08/09/2010 03:44 PM, Nishanth Aravamudan wrote: > On Monday, August 09, 2010 11:43:46 am Nathan Fontenot wrote: >> Update the memory hotplug documentation to reflect the new behaviors of >> memory blocks reflected in sysfs. > > <snip> > >> Index: linux-2.6/Documentation/memory-hotplug.txt >> =================================================================== >> --- linux-2.6.orig/Documentation/memory-hotplug.txt 2010-08-09 07:36:48.000000000 -0500 >> +++ linux-2.6/Documentation/memory-hotplug.txt 2010-08-09 07:59:54.000000000 -0500 > > <snip> > >> -/sys/devices/system/memory/memoryXXX/phys_index >> +/sys/devices/system/memory/memoryXXX/start_phys_index >> +/sys/devices/system/memory/memoryXXX/end_phys_index >> /sys/devices/system/memory/memoryXXX/phys_device >> /sys/devices/system/memory/memoryXXX/state >> /sys/devices/system/memory/memoryXXX/removable >> >> -'phys_index' : read-only and contains section id, same as XXX. > > <snip> > >> +'phys_index' : read-only and contains section id of the first section > > Shouldn't this be "start_phys_index"? Hmmm... looks like I missed something in the documentation. The property should be 'phys_index'. I thought about changing it to 'start_phys_index' but that was rejected. The listing of the files above is wrong in this patch, it should be +/sys/devices/system/memory/memoryXXX/phys_index +/sys/devices/system/memory/memoryXXX/end_phys_index Thanks, Nathan
Index: linux-2.6/Documentation/memory-hotplug.txt =================================================================== --- linux-2.6.orig/Documentation/memory-hotplug.txt 2010-08-09 07:36:48.000000000 -0500 +++ linux-2.6/Documentation/memory-hotplug.txt 2010-08-09 07:59:54.000000000 -0500 @@ -126,36 +126,50 @@ config options. -------------------------------- 4 sysfs files for memory hotplug -------------------------------- -All sections have their device information under /sys/devices/system/memory as +All sections have their device information in sysfs. Each section is part of +a memory block under /sys/devices/system/memory as /sys/devices/system/memory/memoryXXX -(XXX is section id.) +(XXX is the section id.) -Now, XXX is defined as start_address_of_section / section_size. +Now, XXX is defined as (start_address_of_section / section_size) of the first +section contained in the memory block. The files 'phys_index' and +'end_phys_index' under each directory report the beginning and end section id's +for the memory block covered by the sysfs directory. It is expected that all +memory sections in this range are present and no memory holes exist in the +range. Currently there is no way to determine if there is a memory hole, but +the existence of one should not affect the hotplug capabilities of the memory +block. For example, assume 1GiB section size. A device for a memory starting at 0x100000000 is /sys/device/system/memory/memory4 (0x100000000 / 1Gib = 4) This device covers address range [0x100000000 ... 0x140000000) -Under each section, you can see 4 files. +Under each section, you can see 5 files. -/sys/devices/system/memory/memoryXXX/phys_index +/sys/devices/system/memory/memoryXXX/start_phys_index +/sys/devices/system/memory/memoryXXX/end_phys_index /sys/devices/system/memory/memoryXXX/phys_device /sys/devices/system/memory/memoryXXX/state /sys/devices/system/memory/memoryXXX/removable -'phys_index' : read-only and contains section id, same as XXX. -'state' : read-write - at read: contains online/offline state of memory. - at write: user can specify "online", "offline" command -'phys_device': read-only: designed to show the name of physical memory device. - This is not well implemented now. -'removable' : read-only: contains an integer value indicating - whether the memory section is removable or not - removable. A value of 1 indicates that the memory - section is removable and a value of 0 indicates that - it is not removable. +'phys_index' : read-only and contains section id of the first section + in the memory block, same as XXX. +'end_phys_index' : read-only and contains section id of the last section + in the memory block. +'state' : read-write + at read: contains online/offline state of memory. + at write: user can specify "online", "offline" command + which will be performed on al sections in the block. +'phys_device' : read-only: designed to show the name of physical memory + device. This is not well implemented now. +'removable' : read-only: contains an integer value indicating + whether the memory block is removable or not + removable. A value of 1 indicates that the memory + block is removable and a value of 0 indicates that + it is not removable. A memory block is removable only if + every section in the block is removable. NOTE: These directories/files appear after physical memory hotplug phase.
Update the memory hotplug documentation to reflect the new behaviors of memory blocks reflected in sysfs. Signed-off-by: Nathan Fontent <nfont@austin.ibm.com> --- Documentation/memory-hotplug.txt | 46 +++++++++++++++++++++++++-------------- 1 file changed, 30 insertions(+), 16 deletions(-)