Patchwork hw/musicpal: Set loader start address

login
register
mail settings
Submitter Stefan Weil
Date Aug. 9, 2010, 2:52 p.m.
Message ID <1281365527-7229-1-git-send-email-weil@mail.berlios.de>
Download mbox | patch
Permalink /patch/61284/
State New
Headers show

Comments

Stefan Weil - Aug. 9, 2010, 2:52 p.m.
Start address 0x0 did not work with a linux kernel.

Cc: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/musicpal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jan Kiszka - Aug. 19, 2010, 4:50 p.m.
Stefan Weil wrote:
> Start address 0x0 did not work with a linux kernel.

Never tried this, always loaded u-boot this way. But that one is fine
with the shifted offset, so:

Acked-by: Jan Kiszka <jan.kiszka@web.de>


Out of curiosity: Which kernel are you booting on this platform, the
Marvel BSP kernel shipped by Freecom?

JAn

> 
> Cc: Jan Kiszka <jan.kiszka@web.de>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/musicpal.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 33180a2..dc6bc21 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1470,7 +1470,7 @@ static SysBusDeviceInfo musicpal_key_info = {
>  };
>  
>  static struct arm_boot_info musicpal_binfo = {
> -    .loader_start = 0x0,
> +    .loader_start = MP_SRAM_BASE,
>      .board_id = 0x20e,
>  };
>

Patch

diff --git a/hw/musicpal.c b/hw/musicpal.c
index 33180a2..dc6bc21 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -1470,7 +1470,7 @@  static SysBusDeviceInfo musicpal_key_info = {
 };
 
 static struct arm_boot_info musicpal_binfo = {
-    .loader_start = 0x0,
+    .loader_start = MP_SRAM_BASE,
     .board_id = 0x20e,
 };