Patchwork [1/2] mxc_nand: fix build error

login
register
mail settings
Submitter Baruch Siach
Date Aug. 9, 2010, 11:38 a.m.
Message ID <4db426cd74bc8aae80ddcbf666681c3cd439dfc7.1281353601.git.baruch@tkos.co.il>
Download mbox | patch
Permalink /patch/61266/
State New
Headers show

Comments

Baruch Siach - Aug. 9, 2010, 11:38 a.m.
drivers/mtd/nand/mxc_nand.c: In function 'mxc_nand_command':
drivers/mtd/nand/mxc_nand.c:908: error: implicit declaration of function 'send_cmd'

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/mtd/nand/mxc_nand.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Sascha Hauer - Aug. 9, 2010, 12:28 p.m.
On Mon, Aug 09, 2010 at 02:38:13PM +0300, Baruch Siach wrote:
> drivers/mtd/nand/mxc_nand.c: In function 'mxc_nand_command':
> drivers/mtd/nand/mxc_nand.c:908: error: implicit declaration of function 'send_cmd'

This is because you based my series on 2.6.35. With current master this
patch is not necessary.

Sascha

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  drivers/mtd/nand/mxc_nand.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 4032e0b..3092240 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -905,13 +905,13 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
>  
>  			/* Set program pointer to spare region */
>  			if (mtd->writesize == 512)
> -				send_cmd(host, NAND_CMD_READOOB, false);
> +				host->send_cmd(host, NAND_CMD_READOOB, false);
>  		} else {
>  			host->buf_start = column;
>  
>  			/* Set program pointer to page start */
>  			if (mtd->writesize == 512)
> -				send_cmd(host, NAND_CMD_READ0, false);
> +				host->send_cmd(host, NAND_CMD_READ0, false);
>  		}
>  
>  		host->send_cmd(host, command, false);
> -- 
> 1.7.1
> 
>

Patch

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 4032e0b..3092240 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -905,13 +905,13 @@  static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
 
 			/* Set program pointer to spare region */
 			if (mtd->writesize == 512)
-				send_cmd(host, NAND_CMD_READOOB, false);
+				host->send_cmd(host, NAND_CMD_READOOB, false);
 		} else {
 			host->buf_start = column;
 
 			/* Set program pointer to page start */
 			if (mtd->writesize == 512)
-				send_cmd(host, NAND_CMD_READ0, false);
+				host->send_cmd(host, NAND_CMD_READ0, false);
 		}
 
 		host->send_cmd(host, command, false);