settings: remove unnecessary import and associated warning
diff mbox

Message ID 1461126376-3806-1-git-send-email-andrew.donnellan@au1.ibm.com
State Accepted
Delegated to: Russell Currey
Headers show

Commit Message

Andrew Donnellan April 20, 2016, 4:26 a.m. UTC
Remove the unused toml::Decoder import - we reference it explicitly, which
is better.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

---

This fixes building on rustc 1.7+ (as we have #![deny(warnings)] on).
---
 src/settings.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Russell Currey April 20, 2016, 4:41 a.m. UTC | #1
On Wed, 2016-04-20 at 14:26 +1000, Andrew Donnellan wrote:
> Remove the unused toml::Decoder import - we reference it explicitly, which
> is better.
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> 
> ---

Applied to master as of f1a825c764b61064e2bfa7b35017ec940d6d87f4, thanks.

We need to keep Rust up to date wherever we can, I didn't notice this until
after I merged it since I had only tested it on one machine with 1.6, and my
laptop has 1.7.  1.8 is out, we should try to keep up to date manually until
distros can get their shit together.

Arch is the only distribution I've seen so far with up-to-date Rust packages,
including Cargo, included in the package manager, which is disappointing since
it leaves us nothing in the way of server-targeted distributions.

Patch
diff mbox

diff --git a/src/settings.rs b/src/settings.rs
index 77e5e11..904370d 100644
--- a/src/settings.rs
+++ b/src/settings.rs
@@ -15,7 +15,7 @@ 
 //
 
 use toml;
-use toml::{Parser, Value, Decoder};
+use toml::{Parser, Value};
 
 use git2::{Repository, Error};