| Message ID | 1461016722-2637993-1-git-send-email-arnd@arndb.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Arnd Bergmann <arnd@arndb.de> Date: Mon, 18 Apr 2016 23:58:30 +0200 > The w5100-spi driver front-end only makes sense when the w5100 > core driver is enabled, not for a configuration that only has w5300: ... > This adds an appropriate Kconfig dependency. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 630cf09751fe ("net: w5100: support SPI interface mode") Applied, thanks a lot.
diff --git a/drivers/net/ethernet/wiznet/Kconfig b/drivers/net/ethernet/wiznet/Kconfig index 1f15376e9856..f3385a1999a2 100644 --- a/drivers/net/ethernet/wiznet/Kconfig +++ b/drivers/net/ethernet/wiznet/Kconfig @@ -71,7 +71,7 @@ endchoice config WIZNET_W5100_SPI tristate "WIZnet W5100/W5200 Ethernet support for SPI mode" - depends on WIZNET_BUS_ANY + depends on WIZNET_BUS_ANY && WIZNET_W5100 depends on SPI ---help--- In SPI mode host system accesses registers using SPI protocol
The w5100-spi driver front-end only makes sense when the w5100 core driver is enabled, not for a configuration that only has w5300: drivers/net/built-in.o: In function `w5100_spi_remove': drivers/net/ethernet/wiznet/w5100-spi.c:277: undefined reference to `w5100_remove' drivers/net/built-in.o: In function `w5100_spi_probe': drivers/net/ethernet/wiznet/w5100-spi.c:272: undefined reference to `w5100_probe' drivers/net/built-in.o: In function `w5200_spi_init': drivers/net/ethernet/wiznet/w5100-spi.c:125: undefined reference to `w5100_ops_priv' drivers/net/built-in.o: In function `w5200_spi_readbulk': drivers/net/ethernet/wiznet/w5100-spi.c:125: undefined reference to `w5100_ops_priv' drivers/net/built-in.o: In function `w5200_spi_writebulk': drivers/net/ethernet/wiznet/w5100-spi.c:125: undefined reference to `w5100_ops_priv' drivers/net/built-in.o:(.data+0x3ed1c): undefined reference to `w5100_pm_ops' This adds an appropriate Kconfig dependency. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 630cf09751fe ("net: w5100: support SPI interface mode") --- drivers/net/ethernet/wiznet/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)