From patchwork Sat Aug 7 08:26:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/7] UBIFS: switch to RO mode after synchronizing From: Artem Bityutskiy X-Patchwork-Id: 61171 Message-Id: <1281169577-18664-2-git-send-email-dedekind1@gmail.com> To: linux-mtd@lists.infradead.org Cc: Matthieu CASTET , Adrian Hunter Date: Sat, 7 Aug 2010 11:26:11 +0300 From: Artem Bityutskiy In 'ubifs_garbage_collect()' on error path, we first switch to R/O mode, and then synchronize write-buffers (to make sure no data are lost). But the GC write-buffer synchronization will fail, because we are already in R/O mode. This patch re-orders this and makes sure we first synchronize the write-buffer, and then switch to R/O mode. Signed-off-by: Artem Bityutskiy --- fs/ubifs/gc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index 918d158..f89a422 100644 --- a/fs/ubifs/gc.c +++ b/fs/ubifs/gc.c @@ -774,8 +774,8 @@ out_unlock: out: ubifs_assert(ret < 0); ubifs_assert(ret != -ENOSPC && ret != -EAGAIN); - ubifs_ro_mode(c, ret); ubifs_wbuf_sync_nolock(wbuf); + ubifs_ro_mode(c, ret); mutex_unlock(&wbuf->io_mutex); ubifs_return_leb(c, lp.lnum); return ret;