Patchwork powerpc: fix i8042 module build error

login
register
mail settings
Submitter Grant Likely
Date Aug. 6, 2010, 6:42 p.m.
Message ID <20100806183839.32149.6238.stgit@angua>
Download mbox | patch
Permalink /patch/61129/
State Accepted
Headers show

Comments

Grant Likely - Aug. 6, 2010, 6:42 p.m.
of_i8042_{kbd,aux}_irq needs to be exported

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

Stephen and Ben, this fixes up the build error in linux-next.  If you prefer,
I can stuff this patch into my next-powerpc branch.  Ben, I've got other
commits in that branch that I'll be sending to you early next week anyway.

 arch/powerpc/kernel/setup-common.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Stephen Rothwell - Aug. 7, 2010, 12:01 a.m.
Hi Grant,

On Fri, 06 Aug 2010 12:42:12 -0600 Grant Likely <grant.likely@secretlab.ca> wrote:
>
> of_i8042_{kbd,aux}_irq needs to be exported
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> 
> Stephen and Ben, this fixes up the build error in linux-next.  If you prefer,
> I can stuff this patch into my next-powerpc branch.  Ben, I've got other
> commits in that branch that I'll be sending to you early next week anyway.

This failure also exists in Linus' tree, so the earlier this goes to
Linus the better.
Grant Likely - Aug. 7, 2010, 2:54 a.m.
On Fri, Aug 6, 2010 at 6:01 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Grant,
>
> On Fri, 06 Aug 2010 12:42:12 -0600 Grant Likely <grant.likely@secretlab.ca> wrote:
>>
>> of_i8042_{kbd,aux}_irq needs to be exported
>>
>> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>> ---
>>
>> Stephen and Ben, this fixes up the build error in linux-next.  If you prefer,
>> I can stuff this patch into my next-powerpc branch.  Ben, I've got other
>> commits in that branch that I'll be sending to you early next week anyway.
>
> This failure also exists in Linus' tree, so the earlier this goes to
> Linus the better.

Okay then.  Ben, I'll send out my pull request out right away so
you've got it if you want to use it.

Cheers,
g.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Patch

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 15ade0d..9d4882a 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -96,7 +96,9 @@  struct screen_info screen_info = {
 
 /* Variables required to store legacy IO irq routing */
 int of_i8042_kbd_irq;
+EXPORT_SYMBOL_GPL(of_i8042_kbd_irq);
 int of_i8042_aux_irq;
+EXPORT_SYMBOL_GPL(of_i8042_aux_irq);
 
 #ifdef __DO_IRQ_CANON
 /* XXX should go elsewhere eventually */