diff mbox

[U-Boot] arm: dts: vf6: fix DTC unit warnings

Message ID 1460717895-24363-1-git-send-email-hs@denx.de
State Deferred
Delegated to: Tom Rini
Headers show

Commit Message

Heiko Schocher April 15, 2016, 10:58 a.m. UTC
Fix following warnings for all vf6 based boards:

Warning (unit_address_vs_reg): Node /soc/ifc@1530000/board-control@3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /soc/aips-bus@40000000 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /soc/aips-bus@40080000 has a unit name, but no reg property

Signed-off-by: Heiko Schocher <hs@denx.de>
---
This warnings pop up with the DTC compiler:
$ /tmp/dtc/dtc -v
Version: DTC 1.4.1-gbeef80b8

This fixes the compile warnings for:
https://travis-ci.org/u-boot/u-boot/jobs/122880431

see:
https://travis-ci.org/hsdenx/u-boot/jobs/123238780


 arch/arm/dts/ls1021a-qds.dtsi | 2 +-
 arch/arm/dts/vf.dtsi          | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Bhuvanchandra DV April 15, 2016, 2:09 p.m. UTC | #1
On 04/15/2016 04:28 PM, Heiko Schocher wrote:
> Fix following warnings for all vf6 based boards:
>
> Warning (unit_address_vs_reg): Node /soc/ifc@1530000/board-control@3,0/mdio-mux-emi1 has a reg or ranges property, but no unit name
> Warning (unit_address_vs_reg): Node /soc/aips-bus@40000000 has a unit name, but no reg property
> Warning (unit_address_vs_reg): Node /soc/aips-bus@40080000 has a unit name, but no reg property

May be this fix[1] which Stefan Agner submitted lately is also 
applicable here.

[1] https://lkml.org/lkml/2016/4/2/11

>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> This warnings pop up with the DTC compiler:
> $ /tmp/dtc/dtc -v
> Version: DTC 1.4.1-gbeef80b8
>
> This fixes the compile warnings for:
> https://travis-ci.org/u-boot/u-boot/jobs/122880431
>
> see:
> https://travis-ci.org/hsdenx/u-boot/jobs/123238780
>
>
>   arch/arm/dts/ls1021a-qds.dtsi | 2 +-
>   arch/arm/dts/vf.dtsi          | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/dts/ls1021a-qds.dtsi b/arch/arm/dts/ls1021a-qds.dtsi
> index ca9e835..4cb6337 100644
> --- a/arch/arm/dts/ls1021a-qds.dtsi
> +++ b/arch/arm/dts/ls1021a-qds.dtsi
> @@ -138,7 +138,7 @@
>   		device-width = <1>;
>   		ranges = <0 3 0 0x100>;
>
> -		mdio-mux-emi1 {
> +		mdio-mux-emi1@54 {
>   			compatible = "mdio-mux-mmioreg";
>   			mdio-parent-bus = <&mdio0>;
>   			#address-cells = <1>;
> diff --git a/arch/arm/dts/vf.dtsi b/arch/arm/dts/vf.dtsi
> index 1530d2f..99f3269 100644
> --- a/arch/arm/dts/vf.dtsi
> +++ b/arch/arm/dts/vf.dtsi
> @@ -28,7 +28,7 @@
>   		compatible = "simple-bus";
>   		ranges;
>
> -		aips0: aips-bus@40000000 {
> +		aips0: aips-bus_40000000 {
>   			compatible = "fsl,aips-bus", "simple-bus";
>   			#address-cells = <1>;
>   			#size-cells = <1>;
> @@ -115,7 +115,7 @@
>   			};
>   		};
>
> -		aips1: aips-bus@40080000 {
> +		aips1: aips-bus_40080000 {
>   			compatible = "fsl,aips-bus", "simple-bus";
>   			#address-cells = <1>;
>   			#size-cells = <1>;
>
Heiko Schocher April 18, 2016, 4:53 a.m. UTC | #2
Hello Bhuvanchandra DV,

Am 15.04.2016 um 16:09 schrieb Bhuvanchandra DV:
> On 04/15/2016 04:28 PM, Heiko Schocher wrote:
>> Fix following warnings for all vf6 based boards:
>>
>> Warning (unit_address_vs_reg): Node /soc/ifc@1530000/board-control@3,0/mdio-mux-emi1 has a reg or
>> ranges property, but no unit name
>> Warning (unit_address_vs_reg): Node /soc/aips-bus@40000000 has a unit name, but no reg property
>> Warning (unit_address_vs_reg): Node /soc/aips-bus@40080000 has a unit name, but no reg property
>
> May be this fix[1] which Stefan Agner submitted lately is also applicable here.
>
> [1] https://lkml.org/lkml/2016/4/2/11

Yes, better (as it adds the reg property). I hoped for such a comment,
as I cannot search for all missing reg properties!

post a v2 soon.

Thanks!

bye,
Heiko
Bhuvanchandra DV April 18, 2016, 8:37 a.m. UTC | #3
On 04/18/2016 10:23 AM, Heiko Schocher wrote:
> Hello Bhuvanchandra DV,
>
> Am 15.04.2016 um 16:09 schrieb Bhuvanchandra DV:
>> On 04/15/2016 04:28 PM, Heiko Schocher wrote:
>>> Fix following warnings for all vf6 based boards:
>>>
>>> Warning (unit_address_vs_reg): Node
>>> /soc/ifc@1530000/board-control@3,0/mdio-mux-emi1 has a reg or
>>> ranges property, but no unit name
>>> Warning (unit_address_vs_reg): Node /soc/aips-bus@40000000 has a unit
>>> name, but no reg property
>>> Warning (unit_address_vs_reg): Node /soc/aips-bus@40080000 has a unit
>>> name, but no reg property
>>
>> May be this fix[1] which Stefan Agner submitted lately is also
>> applicable here.
>>
>> [1] https://lkml.org/lkml/2016/4/2/11
>
> Yes, better (as it adds the reg property). I hoped for such a comment,
> as I cannot search for all missing reg properties!
>
> post a v2 soon.

Sure! will submit the patch.

>
> Thanks!
>
> bye,
> Heiko
Heiko Schocher April 18, 2016, 9:22 a.m. UTC | #4
Hello Bhuvanchandra DV,

Am 18.04.2016 um 10:37 schrieb Bhuvanchandra DV:
> On 04/18/2016 10:23 AM, Heiko Schocher wrote:
>> Hello Bhuvanchandra DV,
>>
>> Am 15.04.2016 um 16:09 schrieb Bhuvanchandra DV:
>>> On 04/15/2016 04:28 PM, Heiko Schocher wrote:
>>>> Fix following warnings for all vf6 based boards:
>>>>
>>>> Warning (unit_address_vs_reg): Node
>>>> /soc/ifc@1530000/board-control@3,0/mdio-mux-emi1 has a reg or
>>>> ranges property, but no unit name
>>>> Warning (unit_address_vs_reg): Node /soc/aips-bus@40000000 has a unit
>>>> name, but no reg property
>>>> Warning (unit_address_vs_reg): Node /soc/aips-bus@40080000 has a unit
>>>> name, but no reg property
>>>
>>> May be this fix[1] which Stefan Agner submitted lately is also
>>> applicable here.
>>>
>>> [1] https://lkml.org/lkml/2016/4/2/11
>>
>> Yes, better (as it adds the reg property). I hoped for such a comment,
>> as I cannot search for all missing reg properties!
>>
>> post a v2 soon.
>
> Sure! will submit the patch.

Worked in the changes from the post on lkml, I post a v2, thanks!

bye,
Heiko
Tom Rini April 18, 2016, 3:31 p.m. UTC | #5
On Fri, Apr 15, 2016 at 12:58:15PM +0200, Heiko Schocher wrote:

> Fix following warnings for all vf6 based boards:

We're going to defer on this patch for now, thanks.
diff mbox

Patch

diff --git a/arch/arm/dts/ls1021a-qds.dtsi b/arch/arm/dts/ls1021a-qds.dtsi
index ca9e835..4cb6337 100644
--- a/arch/arm/dts/ls1021a-qds.dtsi
+++ b/arch/arm/dts/ls1021a-qds.dtsi
@@ -138,7 +138,7 @@ 
 		device-width = <1>;
 		ranges = <0 3 0 0x100>;
 
-		mdio-mux-emi1 {
+		mdio-mux-emi1@54 {
 			compatible = "mdio-mux-mmioreg";
 			mdio-parent-bus = <&mdio0>;
 			#address-cells = <1>;
diff --git a/arch/arm/dts/vf.dtsi b/arch/arm/dts/vf.dtsi
index 1530d2f..99f3269 100644
--- a/arch/arm/dts/vf.dtsi
+++ b/arch/arm/dts/vf.dtsi
@@ -28,7 +28,7 @@ 
 		compatible = "simple-bus";
 		ranges;
 
-		aips0: aips-bus@40000000 {
+		aips0: aips-bus_40000000 {
 			compatible = "fsl,aips-bus", "simple-bus";
 			#address-cells = <1>;
 			#size-cells = <1>;
@@ -115,7 +115,7 @@ 
 			};
 		};
 
-		aips1: aips-bus@40080000 {
+		aips1: aips-bus_40080000 {
 			compatible = "fsl,aips-bus", "simple-bus";
 			#address-cells = <1>;
 			#size-cells = <1>;