| Message ID | 1460690887-32751-3-git-send-email-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 04/15/2016 06:27 AM, Fam Zheng wrote: > To allow overriding the default locking behavior when opening the image. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > qapi/block-core.json | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 1d09079..2913f3e 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2065,6 +2065,9 @@ > # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1) > # (default: off) > # > +# @lock-image: #optional whether to lock the image (default: true) > +# (Since 2.7) > +# > # Remaining options are determined by the block driver. > # > # Since: 1.7 > @@ -2082,7 +2085,8 @@ > '*stats-account-invalid': 'bool', > '*stats-account-failed': 'bool', > '*stats-intervals': ['int'], > - '*detect-zeroes': 'BlockdevDetectZeroesOptions' }, > + '*detect-zeroes': 'BlockdevDetectZeroesOptions', > + '*lock-image': 'bool' }, > 'discriminator': 'driver', > 'data': { > 'archipelago':'BlockdevOptionsArchipelago', should we touch qmp-command.hx?
On Sat, 04/16 13:48, Denis V. Lunev wrote: > On 04/15/2016 06:27 AM, Fam Zheng wrote: > > To allow overriding the default locking behavior when opening the image. > > > > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > qapi/block-core.json | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index 1d09079..2913f3e 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -2065,6 +2065,9 @@ > > # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1) > > # (default: off) > > # > > +# @lock-image: #optional whether to lock the image (default: true) > > +# (Since 2.7) > > +# > > # Remaining options are determined by the block driver. > > # > > # Since: 1.7 > > @@ -2082,7 +2085,8 @@ > > '*stats-account-invalid': 'bool', > > '*stats-account-failed': 'bool', > > '*stats-intervals': ['int'], > > - '*detect-zeroes': 'BlockdevDetectZeroesOptions' }, > > + '*detect-zeroes': 'BlockdevDetectZeroesOptions', > > + '*lock-image': 'bool' }, > > 'discriminator': 'driver', > > 'data': { > > 'archipelago':'BlockdevOptionsArchipelago', > should we touch qmp-command.hx? These fields have no documentation there. Fam
diff --git a/qapi/block-core.json b/qapi/block-core.json index 1d09079..2913f3e 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2065,6 +2065,9 @@ # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1) # (default: off) # +# @lock-image: #optional whether to lock the image (default: true) +# (Since 2.7) +# # Remaining options are determined by the block driver. # # Since: 1.7 @@ -2082,7 +2085,8 @@ '*stats-account-invalid': 'bool', '*stats-account-failed': 'bool', '*stats-intervals': ['int'], - '*detect-zeroes': 'BlockdevDetectZeroesOptions' }, + '*detect-zeroes': 'BlockdevDetectZeroesOptions', + '*lock-image': 'bool' }, 'discriminator': 'driver', 'data': { 'archipelago':'BlockdevOptionsArchipelago',
To allow overriding the default locking behavior when opening the image. Signed-off-by: Fam Zheng <famz@redhat.com> --- qapi/block-core.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)