Message ID | 1460641197-12610-1-git-send-email-julien.boibessot@free.fr |
---|---|
State | Changes Requested |
Headers | show |
Hello, On Thu, 14 Apr 2016 15:39:57 +0200, julien.boibessot@free.fr wrote: > From: Julien BOIBESSOT <julien.boibessot@armadeus.com> > > APF6 is an i.MX6 based SOM with an optional Cyclone 5 GX FPGA. > > Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com> > --- > configs/armadeus_apf6_defconfig | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 configs/armadeus_apf6_defconfig > > diff --git a/configs/armadeus_apf6_defconfig b/configs/armadeus_apf6_defconfig > new file mode 100644 > index 0000000..a51dd5f > --- /dev/null > +++ b/configs/armadeus_apf6_defconfig > @@ -0,0 +1,27 @@ > +BR2_arm=y > +BR2_cortex_a9=y > +BR2_ARM_ENABLE_NEON=y > +BR2_ARM_ENABLE_VFP=y > +BR2_ARM_FPU_VFPV3=y > + > +# Linux headers same as kernel, a 3.19 series > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_19=y > + > +# System > +BR2_TARGET_GENERIC_HOSTNAME="apf6" > +BR2_TARGET_GENERIC_ISSUE="Welcome to Armadeus development platform !" > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3" > + > +# Kernel > +BR2_LINUX_KERNEL=y > +BR2_LINUX_KERNEL_CUSTOM_VERSION=y > +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="3.19.8" > +BR2_LINUX_KERNEL_PATCH="http://sourceforge.net/projects/armadeus/files/armadeus/armadeus-6.0/patches/linux-3.19-armadeus.patch.tar.gz" > +BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7" > +BR2_LINUX_KERNEL_DTS_SUPPORT=y > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-apf6dev imx6dl-apf6dev" > +BR2_LINUX_KERNEL_INSTALL_TARGET=y Is it expected that you're not building any bootloader here? Also, this needs a readme.txt to explain how to use this defconfig. If you're putting off SD card, then please use genimage to generate a complete SD card image. If you're booting out of NAND, please include instructions on how to flash the resulting system. But does it make sense to have a defconfig for a SOM ? A SOM as-is generally can't be booted, it needs to be put on some base-board, right ? Best regards, Thomas
Hello Thomas, thanks for the review ! On 15/04/2016 09:54, Thomas Petazzoni wrote: > Hello, > > On Thu, 14 Apr 2016 15:39:57 +0200, julien.boibessot@free.fr wrote: >> From: Julien BOIBESSOT <julien.boibessot@armadeus.com> >> >> APF6 is an i.MX6 based SOM with an optional Cyclone 5 GX FPGA. >> >> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com> >> --- >> configs/armadeus_apf6_defconfig | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 configs/armadeus_apf6_defconfig >> >> diff --git a/configs/armadeus_apf6_defconfig b/configs/armadeus_apf6_defconfig >> new file mode 100644 >> index 0000000..a51dd5f >> --- /dev/null >> +++ b/configs/armadeus_apf6_defconfig >> @@ -0,0 +1,27 @@ >> +BR2_arm=y >> +BR2_cortex_a9=y >> +BR2_ARM_ENABLE_NEON=y >> +BR2_ARM_ENABLE_VFP=y >> +BR2_ARM_FPU_VFPV3=y >> + >> +# Linux headers same as kernel, a 3.19 series >> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_19=y >> + >> +# System >> +BR2_TARGET_GENERIC_HOSTNAME="apf6" >> +BR2_TARGET_GENERIC_ISSUE="Welcome to Armadeus development platform !" >> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3" >> + >> +# Kernel >> +BR2_LINUX_KERNEL=y >> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y >> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="3.19.8" >> +BR2_LINUX_KERNEL_PATCH="http://sourceforge.net/projects/armadeus/files/armadeus/armadeus-6.0/patches/linux-3.19-armadeus.patch.tar.gz" >> +BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7" >> +BR2_LINUX_KERNEL_DTS_SUPPORT=y >> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-apf6dev imx6dl-apf6dev" >> +BR2_LINUX_KERNEL_INSTALL_TARGET=y > Is it expected that you're not building any bootloader here? yes. it doesn't work for the moment with latest BR. > > Also, this needs a readme.txt to explain how to use this defconfig. If > you're putting off SD card, then please use genimage to generate a > complete SD card image. If you're booting out of NAND, please include > instructions on how to flash the resulting system. Yes you're right I was a little short on comments. APF6 has an onboard eMMC, so no need for genimage to build basic rootfs. > > But does it make sense to have a defconfig for a SOM ? A SOM as-is > generally can't be booted, it needs to be put on some base-board, > right ? Nop, of course support includes development boards and it will be more explicit in my next patch. Best regards, Julien
Hello, On Fri, 15 Apr 2016 16:32:05 +0200, Julien Boibessot wrote: > > Is it expected that you're not building any bootloader here? > > yes. it doesn't work for the moment with latest BR. It works with an older Buildroot? What is the problem you encounter? > > Also, this needs a readme.txt to explain how to use this defconfig. If > > you're putting off SD card, then please use genimage to generate a > > complete SD card image. If you're booting out of NAND, please include > > instructions on how to flash the resulting system. > > Yes you're right I was a little short on comments. > APF6 has an onboard eMMC, so no need for genimage to build basic rootfs. Hm, isn't genimage capable of building a complete image for an eMMC ? In any case, you should include a readme.txt that documents how to flash the resulting system on the board. > > But does it make sense to have a defconfig for a SOM ? A SOM as-is > > generally can't be booted, it needs to be put on some base-board, > > right ? > > Nop, of course support includes development boards and it will be more > explicit in my next patch. Thanks. Thomas
Thomas, On 15/04/2016 17:17, Thomas Petazzoni wrote: > Hello, > > On Fri, 15 Apr 2016 16:32:05 +0200, Julien Boibessot wrote: > >>> Is it expected that you're not building any bootloader here? >> yes. it doesn't work for the moment with latest BR. > It works with an older Buildroot? What is the problem you encounter? cf my previous RFC/PATCH commented by Arnout yesterday evening (https://patchwork.ozlabs.org/patch/610481/): we need to download patches to build U-Boot and BR dl infra complains about missing hash. > >>> Also, this needs a readme.txt to explain how to use this defconfig. If >>> you're putting off SD card, then please use genimage to generate a >>> complete SD card image. If you're booting out of NAND, please include >>> instructions on how to flash the resulting system. >> Yes you're right I was a little short on comments. >> APF6 has an onboard eMMC, so no need for genimage to build basic rootfs. > Hm, isn't genimage capable of building a complete image for an eMMC ? Well for me no. eMMC are physically partionned and I don't think you can flash a big file with everything inside. I don't remember with who I had this discussion during BRDD on February :-) Internally we use genimage to build a kernel+rootfs image for "user dat"a partition of our eMMC but it's only for factory purpose and I'm not sure I have to complicate the defconfig for something no one uses. Should I ? (http://www.armadeus.com/wiki/index.php?title=EMMC) > > In any case, you should include a readme.txt that documents how to > flash the resulting system on the board. yeap that's the goal of the patch I sent this afternoon: https://patchwork.ozlabs.org/patch/610964/ Once accepted, I will update it in next version on my APF6 patch. Thanks ! Regards, Julien > >>> But does it make sense to have a defconfig for a SOM ? A SOM as-is >>> generally can't be booted, it needs to be put on some base-board, >>> right ? >> Nop, of course support includes development boards and it will be more >> explicit in my next patch. > Thanks. > > Thomas
Hello, On Fri, 15 Apr 2016 17:45:37 +0200, Julien Boibessot wrote: > cf my previous RFC/PATCH commented by Arnout yesterday evening > (https://patchwork.ozlabs.org/patch/610481/): > we need to download patches to build U-Boot and BR dl infra complains > about missing hash. Then you should send a series of patches, with the first patch fixing the U-Boot hash issue, and the second patch adding the APF6 defconfig with U-Boot support. This way, we can clearly see the big picture and the dependencies between your contributions. > Well for me no. eMMC are physically partionned and I don't think you can > flash a big file with everything inside. > I don't remember with who I had this discussion during BRDD on February :-) > Internally we use genimage to build a kernel+rootfs image for "user > dat"a partition of our eMMC but it's only for factory purpose and I'm > not sure I have to complicate the defconfig for something no one uses. > Should I ? > (http://www.armadeus.com/wiki/index.php?title=EMMC) OK. Having a genimage generated image for the "user data" part still makes sense IMO. > > In any case, you should include a readme.txt that documents how to > > flash the resulting system on the board. > > yeap that's the goal of the patch I sent this afternoon: > https://patchwork.ozlabs.org/patch/610964/ > Once accepted, I will update it in next version on my APF6 patch. Same thing, it would be a lot better if you were doing patch series rather than individual patches that seem to be unrelated, but are in fact inter-related. Thanks! Thomas
diff --git a/configs/armadeus_apf6_defconfig b/configs/armadeus_apf6_defconfig new file mode 100644 index 0000000..a51dd5f --- /dev/null +++ b/configs/armadeus_apf6_defconfig @@ -0,0 +1,27 @@ +BR2_arm=y +BR2_cortex_a9=y +BR2_ARM_ENABLE_NEON=y +BR2_ARM_ENABLE_VFP=y +BR2_ARM_FPU_VFPV3=y + +# Linux headers same as kernel, a 3.19 series +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_19=y + +# System +BR2_TARGET_GENERIC_HOSTNAME="apf6" +BR2_TARGET_GENERIC_ISSUE="Welcome to Armadeus development platform !" +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3" + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_VERSION=y +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="3.19.8" +BR2_LINUX_KERNEL_PATCH="http://sourceforge.net/projects/armadeus/files/armadeus/armadeus-6.0/patches/linux-3.19-armadeus.patch.tar.gz" +BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-apf6dev imx6dl-apf6dev" +BR2_LINUX_KERNEL_INSTALL_TARGET=y + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y