Patchwork [Tracing] Fix a build warning

login
register
mail settings
Submitter Prerna Saxena
Date Aug. 5, 2010, 12:08 p.m.
Message ID <20100805173853.3cea0c93@zephyr>
Download mbox | patch
Permalink /patch/61002/
State New
Headers show

Comments

Prerna Saxena - Aug. 5, 2010, 12:08 p.m.
A build warning arising out of 'incompatible pointer assignment' shows 
up at times. This will take care of it.

Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
---
 vl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Aug. 5, 2010, 2:26 p.m.
On Thu, Aug 5, 2010 at 1:08 PM, Prerna Saxena <prerna@linux.vnet.ibm.com> wrote:
> A build warning arising out of 'incompatible pointer assignment' shows
> up at times. This will take care of it.
>
> Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
> ---
>  vl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks Prerna.  I noticed the warning and added const when merging
your trace file name patch:

http://repo.or.cz/w/qemu/stefanha.git/commitdiff/ea06bd2dd2e168059bde1e8c4d1003bb7b07dfe9

Stefan

Patch

diff --git a/vl.c b/vl.c
index 46314d4..989c35b 100644
--- a/vl.c
+++ b/vl.c
@@ -1827,7 +1827,7 @@  int main(int argc, char **argv, char **envp)
     int defconfig = 1;
 
 #ifdef CONFIG_SIMPLE_TRACE
-    char *trace_file = NULL;
+    const char *trace_file = NULL;
 #endif
     atexit(qemu_run_exit_notifiers);
     error_set_progname(argv[0]);