Patchwork [06/15] drivers: ide: ide-tape.c removed duplicated #include

login
register
mail settings
Submitter Andrea Gelmini
Date Aug. 5, 2010, 1:51 p.m.
Message ID <1281016299-23958-6-git-send-email-andrea.gelmini@gelma.net>
Download mbox | patch
Permalink /patch/60972/
State Rejected
Delegated to: David Miller
Headers show

Comments

Andrea Gelmini - Aug. 5, 2010, 1:51 p.m.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 drivers/ide/ide-tape.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Borislav Petkov - Aug. 5, 2010, 2:27 p.m.
From: Andrea Gelmini <andrea.gelmini@gelma.net>
Date: Thu, Aug 05, 2010 at 03:51:30PM +0200

Hi,

> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  drivers/ide/ide-tape.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index b072328..24d0332 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -35,7 +35,6 @@
>  #include <linux/slab.h>
>  #include <linux/pci.h>
>  #include <linux/ide.h>
> -#include <linux/smp_lock.h>
>  #include <linux/completion.h>
>  #include <linux/bitops.h>
>  #include <linux/mutex.h>

I don't see the duplicates, are you sure about this?
Andrea Gelmini - Aug. 5, 2010, 3:06 p.m.
2010/8/5 Borislav Petkov <bp@alien8.de>:

Hi Borislav,
   and thanks for your answer.

> I don't see the duplicates, are you sure about this?
   You are right. I'm wrong.
   Well, I'm trying to figure out how I did  this stupid mistake.
   I was playing with some cloned kernel tree, to check if I found
things already fixed in next tree.
   Maybe I made a mess pushing and pulling.

   Sorry, I didn't mean to waste your time.

Thanks again,
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Borislav Petkov - Aug. 5, 2010, 3:31 p.m.
From: Andrea Gelmini <andrea.gelmini@gelma.net>
Date: Thu, Aug 05, 2010 at 05:06:03PM +0200

> 2010/8/5 Borislav Petkov <bp@alien8.de>:
> 
> Hi Borislav,
>    and thanks for your answer.
> 
> > I don't see the duplicates, are you sure about this?
>    You are right. I'm wrong.
>    Well, I'm trying to figure out how I did  this stupid mistake.
>    I was playing with some cloned kernel tree, to check if I found
> things already fixed in next tree.
>    Maybe I made a mess pushing and pulling.
> 
>    Sorry, I didn't mean to waste your time.

You didn't, no worries. You better keep looking, the next real bug is
right around the corner :).

Patch

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index b072328..24d0332 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -35,7 +35,6 @@ 
 #include <linux/slab.h>
 #include <linux/pci.h>
 #include <linux/ide.h>
-#include <linux/smp_lock.h>
 #include <linux/completion.h>
 #include <linux/bitops.h>
 #include <linux/mutex.h>