Patchwork usbnet: remove noisy and hardly useful printk

login
register
mail settings
Submitter Christian Samsel
Date Aug. 5, 2010, 8:14 a.m.
Message ID <1280996076-19708-1-git-send-email-christian.samsel@rwth-aachen.de>
Download mbox | patch
Permalink /patch/60936/
State Accepted
Delegated to: David Miller
Headers show

Comments

Christian Samsel - Aug. 5, 2010, 8:14 a.m.
With turned on hspa modem (Dell 5530 internal card) and activated usb auto
suspend, my system gets up 100 "usbnet_resume has delayed data" per
minute. I didnt noticed any pathological behaviour, so just drop
this message. if any objections, please at least change it to _DEBUG.

Signed-off-by: Christian Samsel <christian.samsel@rwth-aachen.de>
---
 drivers/net/usb/usbnet.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
David Miller - Aug. 5, 2010, 8:21 p.m.
From: Christian Samsel <christian.samsel@rwth-aachen.de>
Date: Thu, 05 Aug 2010 10:14:36 +0200

> With turned on hspa modem (Dell 5530 internal card) and activated usb auto
> suspend, my system gets up 100 "usbnet_resume has delayed data" per
> minute. I didnt noticed any pathological behaviour, so just drop
> this message. if any objections, please at least change it to _DEBUG.
> 
> Signed-off-by: Christian Samsel <christian.samsel@rwth-aachen.de>

I agree, and I'll apply this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 3b03794..7f62e2d 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1457,7 +1457,6 @@  int usbnet_resume (struct usb_interface *intf)
 		spin_lock_irq(&dev->txq.lock);
 		while ((res = usb_get_from_anchor(&dev->deferred))) {
 
-			printk(KERN_INFO"%s has delayed data\n", __func__);
 			skb = (struct sk_buff *)res->context;
 			retval = usb_submit_urb(res, GFP_ATOMIC);
 			if (retval < 0) {