Message ID | 1460440299-26654-1-git-send-email-kraxel@redhat.com |
---|---|
State | New |
Headers | show |
On 04/11/2016 11:51 PM, Gerd Hoffmann wrote: > "_x" must be "(_x)" otherwise things fail if you pass in expressions. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > include/hw/virtio/virtio-input.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/include/hw/virtio/virtio-input.h b/include/hw/virtio/virtio-input.h index af1c207..169adee 100644 --- a/include/hw/virtio/virtio-input.h +++ b/include/hw/virtio/virtio-input.h @@ -15,13 +15,13 @@ typedef struct virtio_input_event virtio_input_event; #if defined(HOST_WORDS_BIGENDIAN) # define const_le32(_x) \ - (((_x & 0x000000ffU) << 24) | \ - ((_x & 0x0000ff00U) << 8) | \ - ((_x & 0x00ff0000U) >> 8) | \ - ((_x & 0xff000000U) >> 24)) + ((((_x) & 0x000000ffU) << 24) | \ + (((_x) & 0x0000ff00U) << 8) | \ + (((_x) & 0x00ff0000U) >> 8) | \ + (((_x) & 0xff000000U) >> 24)) # define const_le16(_x) \ - (((_x & 0x00ff) << 8) | \ - ((_x & 0xff00) >> 8)) + ((((_x) & 0x00ff) << 8) | \ + (((_x) & 0xff00) >> 8)) #else # define const_le32(_x) (_x) # define const_le16(_x) (_x)
"_x" must be "(_x)" otherwise things fail if you pass in expressions. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- include/hw/virtio/virtio-input.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)