diff mbox

[3/4] board/minnowboard-max: Add more peripherals and features to the kernel

Message ID 1460438965-28065-4-git-send-email-ezequiel@vanguardiasur.com.ar
State Superseded
Headers show

Commit Message

Ezequiel Garcia April 12, 2016, 5:29 a.m. UTC
This commit enables support for:
  * HDMI audio
  * Support for user-provided EDID firmware
    (useful to workaround broken monitors)
  * Evdev interface
  * System V IPC (required by ALSA)
  * POSIX message queue
  * fhandle syscall
  * cgroups

The options are quite common and make the system more useful.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
 board/minnowboard-max/linux.config | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Arnout Vandecappelle April 12, 2016, 11:29 p.m. UTC | #1
On 04/12/16 07:29, Ezequiel Garcia wrote:
> This commit enables support for:
>    * HDMI audio
>    * Support for user-provided EDID firmware
>      (useful to workaround broken monitors)
>    * Evdev interface
>    * System V IPC (required by ALSA)
>    * POSIX message queue
>    * fhandle syscall
>    * cgroups

  Why cgroups?

>
> The options are quite common and make the system more useful.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
>   board/minnowboard-max/linux.config | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/board/minnowboard-max/linux.config b/board/minnowboard-max/linux.config
> index abb7fdce9861..f80170b9b81d 100644
> --- a/board/minnowboard-max/linux.config
> +++ b/board/minnowboard-max/linux.config
> @@ -1,4 +1,8 @@
> +CONFIG_SYSVIPC=y
> +CONFIG_POSIX_MQUEUE=y
> +CONFIG_FHANDLE=y
>   CONFIG_NO_HZ=y
> +CONFIG_CGROUPS=y
>   CONFIG_SMP=y
>   CONFIG_X86_INTEL_LPSS=y
>   CONFIG_MATOM=y
> @@ -13,12 +17,15 @@ CONFIG_NET=y
>   CONFIG_PACKET=y
>   CONFIG_UNIX=y
>   CONFIG_INET=y
> +CONFIG_DEVTMPFS=y
> +CONFIG_DEVTMPFS_MOUNT=y

  This is added automatically by Buildroot. That said, it's better if it's 
already in the defconfig.

>   CONFIG_CHR_DEV_SG=y
>   CONFIG_ATA=y
>   CONFIG_SATA_AHCI=y
>   CONFIG_ATA_PIIX=y
>   CONFIG_NETDEVICES=y
>   CONFIG_R8169=y
> +CONFIG_INPUT_EVDEV=y
>   CONFIG_SERIAL_8250=y
>   CONFIG_SERIAL_8250_CONSOLE=y
>   CONFIG_SERIAL_8250_DW=y
> @@ -33,7 +40,15 @@ CONFIG_GPIOLIB=y
>   CONFIG_GPIO_SYSFS=y
>   CONFIG_AGP=y
>   CONFIG_DRM=y
> +CONFIG_DRM_LOAD_EDID_FIRMWARE=y
>   CONFIG_DRM_I915=y
> +CONFIG_SOUND=y
> +CONFIG_SND=y
> +# CONFIG_SND_DRIVERS is not set
> +CONFIG_SND_HDA_INTEL=y
> +CONFIG_SND_HDA_CODEC_HDMI=y
> +# CONFIG_SND_SPI is not set
> +# CONFIG_SND_USB is not set
>   CONFIG_USB=y
>   CONFIG_USB_XHCI_HCD=y
>   CONFIG_NOP_USB_XCEIV=y
> @@ -44,3 +59,5 @@ CONFIG_MMC_SDHCI_ACPI=y
>   CONFIG_PWM=y
>   CONFIG_PWM_LPSS=y
>   CONFIG_EXT4_FS=y
> +CONFIG_AUTOFS4_FS=y

  Why?

> +CONFIG_TMPFS_POSIX_ACL=y

  Why?

  Regards,
  Arnout
>
Ezequiel Garcia April 12, 2016, 11:55 p.m. UTC | #2
On 12 April 2016 at 20:29, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 04/12/16 07:29, Ezequiel Garcia wrote:
>>
>> This commit enables support for:
>>    * HDMI audio
>>    * Support for user-provided EDID firmware
>>      (useful to workaround broken monitors)
>>    * Evdev interface
>>    * System V IPC (required by ALSA)
>>    * POSIX message queue
>>    * fhandle syscall
>>    * cgroups
>
>
>  Why cgroups?
>

Well, in fact... the commit log is not correct. My initial intention
was to add IPC (required by ALSA), HDMI audio and evdev.

As you can imagine, the goal was to play supertuxkart.

The rest of the configs got added by Buildroot, because
of the systemd presence:

$ cat linux/linux.mk
[..]
        $(if $(BR2_PACKAGE_SYSTEMD),
                $(call KCONFIG_ENABLE_OPT,CONFIG_CGROUPS,$(@D)/.config)
                $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
                $(call KCONFIG_ENABLE_OPT,CONFIG_FHANDLE,$(@D)/.config)
                $(call KCONFIG_ENABLE_OPT,CONFIG_AUTOFS4_FS,$(@D)/.config)
                $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_ACL,$(@D)/.config)
                $(call
KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_XATTR,$(@D)/.config))

Same goes for devtmpfs, but that's a different matter. I suppose I was
originally working with BR2_ROOTFS_DEVICE_CREATION_STATIC=y and
so carried the options (not needed with systemd of course).

They options got here because I manually added the new options
and updated the config from a defconfig using savedefconfig.

Anyway: I don't care at all about them, I just want audio and evdev :-)

Regarding using systemd, I'll reply to the other patch.

>>
>> The options are quite common and make the system more useful.
>>
>> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
>> ---
>>   board/minnowboard-max/linux.config | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/board/minnowboard-max/linux.config
>> b/board/minnowboard-max/linux.config
>> index abb7fdce9861..f80170b9b81d 100644
>> --- a/board/minnowboard-max/linux.config
>> +++ b/board/minnowboard-max/linux.config
>> @@ -1,4 +1,8 @@
>> +CONFIG_SYSVIPC=y
>> +CONFIG_POSIX_MQUEUE=y
>> +CONFIG_FHANDLE=y
>>   CONFIG_NO_HZ=y
>> +CONFIG_CGROUPS=y
>>   CONFIG_SMP=y
>>   CONFIG_X86_INTEL_LPSS=y
>>   CONFIG_MATOM=y
>> @@ -13,12 +17,15 @@ CONFIG_NET=y
>>   CONFIG_PACKET=y
>>   CONFIG_UNIX=y
>>   CONFIG_INET=y
>> +CONFIG_DEVTMPFS=y
>> +CONFIG_DEVTMPFS_MOUNT=y
>
>
>  This is added automatically by Buildroot. That said, it's better if it's
> already in the defconfig.
>
>
>>   CONFIG_CHR_DEV_SG=y
>>   CONFIG_ATA=y
>>   CONFIG_SATA_AHCI=y
>>   CONFIG_ATA_PIIX=y
>>   CONFIG_NETDEVICES=y
>>   CONFIG_R8169=y
>> +CONFIG_INPUT_EVDEV=y
>>   CONFIG_SERIAL_8250=y
>>   CONFIG_SERIAL_8250_CONSOLE=y
>>   CONFIG_SERIAL_8250_DW=y
>> @@ -33,7 +40,15 @@ CONFIG_GPIOLIB=y
>>   CONFIG_GPIO_SYSFS=y
>>   CONFIG_AGP=y
>>   CONFIG_DRM=y
>> +CONFIG_DRM_LOAD_EDID_FIRMWARE=y
>>   CONFIG_DRM_I915=y
>> +CONFIG_SOUND=y
>> +CONFIG_SND=y
>> +# CONFIG_SND_DRIVERS is not set
>> +CONFIG_SND_HDA_INTEL=y
>> +CONFIG_SND_HDA_CODEC_HDMI=y
>> +# CONFIG_SND_SPI is not set
>> +# CONFIG_SND_USB is not set
>>   CONFIG_USB=y
>>   CONFIG_USB_XHCI_HCD=y
>>   CONFIG_NOP_USB_XCEIV=y
>> @@ -44,3 +59,5 @@ CONFIG_MMC_SDHCI_ACPI=y
>>   CONFIG_PWM=y
>>   CONFIG_PWM_LPSS=y
>>   CONFIG_EXT4_FS=y
>> +CONFIG_AUTOFS4_FS=y
>
>
>  Why?
>
>> +CONFIG_TMPFS_POSIX_ACL=y
>
>
>  Why?
>
>  Regards,
>  Arnout
>>
>>
>
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Peter Korsgaard April 13, 2016, 9:02 p.m. UTC | #3
>>>>> "Ezequiel" == Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

 > On 12 April 2016 at 20:29, Arnout Vandecappelle <arnout@mind.be> wrote:
 >> On 04/12/16 07:29, Ezequiel Garcia wrote:
 >>> 
 >>> This commit enables support for:
 >>> * HDMI audio
 >>> * Support for user-provided EDID firmware
 >>> (useful to workaround broken monitors)
 >>> * Evdev interface
 >>> * System V IPC (required by ALSA)
 >>> * POSIX message queue
 >>> * fhandle syscall
 >>> * cgroups
 >> 
 >> 
 >> Why cgroups?
 >> 

 > Well, in fact... the commit log is not correct. My initial intention
 > was to add IPC (required by ALSA), HDMI audio and evdev.

 > As you can imagine, the goal was to play supertuxkart.

 > The rest of the configs got added by Buildroot, because
 > of the systemd presence:

Ok, will you send a new version with only the needed changes?

Thanks.
Ezequiel Garcia April 13, 2016, 10:02 p.m. UTC | #4
On 13 April 2016 at 18:02, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Ezequiel" == Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
>
>  > On 12 April 2016 at 20:29, Arnout Vandecappelle <arnout@mind.be> wrote:
>  >> On 04/12/16 07:29, Ezequiel Garcia wrote:
>  >>>
>  >>> This commit enables support for:
>  >>> * HDMI audio
>  >>> * Support for user-provided EDID firmware
>  >>> (useful to workaround broken monitors)
>  >>> * Evdev interface
>  >>> * System V IPC (required by ALSA)
>  >>> * POSIX message queue
>  >>> * fhandle syscall
>  >>> * cgroups
>  >>
>  >>
>  >> Why cgroups?
>  >>
>
>  > Well, in fact... the commit log is not correct. My initial intention
>  > was to add IPC (required by ALSA), HDMI audio and evdev.
>
>  > As you can imagine, the goal was to play supertuxkart.
>
>  > The rest of the configs got added by Buildroot, because
>  > of the systemd presence:
>
> Ok, will you send a new version with only the needed changes?
>

Yup.
diff mbox

Patch

diff --git a/board/minnowboard-max/linux.config b/board/minnowboard-max/linux.config
index abb7fdce9861..f80170b9b81d 100644
--- a/board/minnowboard-max/linux.config
+++ b/board/minnowboard-max/linux.config
@@ -1,4 +1,8 @@ 
+CONFIG_SYSVIPC=y
+CONFIG_POSIX_MQUEUE=y
+CONFIG_FHANDLE=y
 CONFIG_NO_HZ=y
+CONFIG_CGROUPS=y
 CONFIG_SMP=y
 CONFIG_X86_INTEL_LPSS=y
 CONFIG_MATOM=y
@@ -13,12 +17,15 @@  CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
 CONFIG_INET=y
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_ATA=y
 CONFIG_SATA_AHCI=y
 CONFIG_ATA_PIIX=y
 CONFIG_NETDEVICES=y
 CONFIG_R8169=y
+CONFIG_INPUT_EVDEV=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_8250_DW=y
@@ -33,7 +40,15 @@  CONFIG_GPIOLIB=y
 CONFIG_GPIO_SYSFS=y
 CONFIG_AGP=y
 CONFIG_DRM=y
+CONFIG_DRM_LOAD_EDID_FIRMWARE=y
 CONFIG_DRM_I915=y
+CONFIG_SOUND=y
+CONFIG_SND=y
+# CONFIG_SND_DRIVERS is not set
+CONFIG_SND_HDA_INTEL=y
+CONFIG_SND_HDA_CODEC_HDMI=y
+# CONFIG_SND_SPI is not set
+# CONFIG_SND_USB is not set
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_NOP_USB_XCEIV=y
@@ -44,3 +59,5 @@  CONFIG_MMC_SDHCI_ACPI=y
 CONFIG_PWM=y
 CONFIG_PWM_LPSS=y
 CONFIG_EXT4_FS=y
+CONFIG_AUTOFS4_FS=y
+CONFIG_TMPFS_POSIX_ACL=y