Patchwork parport on Sun Blade 2500 Red ?

login
register
mail settings
Submitter David Miller
Date Aug. 5, 2010, 12:30 a.m.
Message ID <20100804.173043.116396197.davem@davemloft.net>
Download mbox | patch
Permalink /patch/60911/
State Accepted
Delegated to: David Miller
Headers show

Comments

David Miller - Aug. 5, 2010, 12:30 a.m.
From: Mikael Pettersson <mikpe@it.uu.se>
Date: Mon, 3 May 2010 16:12:00 +0200

> According to Sun's documentation, a Sun Blade 2500 Red includes
> a PC-style parallel port.
> 
> If I build a kernel (any recent 2.6 kernel) with plain parport
> support (PARPORT_PC=y), there are no kernel messages of any kind
> related to parport, indicating it didn't find one.

Just a missing device ID in the driver, give this patch a try:

--------------------
sparc64: Add missing ID to parport probing code.

SunBlade-2500 has 'parallel' device node with compatible
property "pnpALI,1533,3" so add that to the ID table.

Reported-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/include/asm/parport.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Mikael Pettersson - Aug. 8, 2010, 7:33 p.m.
David Miller writes:
 > From: Mikael Pettersson <mikpe@it.uu.se>
 > Date: Mon, 3 May 2010 16:12:00 +0200
 > 
 > > According to Sun's documentation, a Sun Blade 2500 Red includes
 > > a PC-style parallel port.
 > > 
 > > If I build a kernel (any recent 2.6 kernel) with plain parport
 > > support (PARPORT_PC=y), there are no kernel messages of any kind
 > > related to parport, indicating it didn't find one.
 > 
 > Just a missing device ID in the driver, give this patch a try:
 > 
 > --------------------
 > sparc64: Add missing ID to parport probing code.
 > 
 > SunBlade-2500 has 'parallel' device node with compatible
 > property "pnpALI,1533,3" so add that to the ID table.
 > 
 > Reported-by: Mikael Pettersson <mikpe@it.uu.se>
 > Signed-off-by: David S. Miller <davem@davemloft.net>

Thanks, seems to work.  I now get:

parport0: PC-style at 0x7fe01000378 (0x7fe01000778), irq 24 [PCSPP,TRISTATE]

Tested-by: Mikael Pettersson <mikpe@it.uu.se>

 > ---
 >  arch/sparc/include/asm/parport.h |    4 ++++
 >  1 files changed, 4 insertions(+), 0 deletions(-)
 > 
 > diff --git a/arch/sparc/include/asm/parport.h b/arch/sparc/include/asm/parport.h
 > index c333b8d..d21ad50 100644
 > --- a/arch/sparc/include/asm/parport.h
 > +++ b/arch/sparc/include/asm/parport.h
 > @@ -228,6 +228,10 @@ static const struct of_device_id ecpp_match[] = {
 >  		.name = "parallel",
 >  		.compatible = "ns87317-ecpp",
 >  	},
 > +	{
 > +		.name = "parallel",
 > +		.compatible = "pnpALI,1533,3",
 > +	},
 >  	{},
 >  };
 >  
 > -- 
 > 1.7.1.1
 > 
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Aug. 9, 2010, 3 a.m.
From: Mikael Pettersson <mikpe@it.uu.se>
Date: Sun, 8 Aug 2010 21:33:43 +0200

> Thanks, seems to work.  I now get:
> 
> parport0: PC-style at 0x7fe01000378 (0x7fe01000778), irq 24 [PCSPP,TRISTATE]
> 
> Tested-by: Mikael Pettersson <mikpe@it.uu.se>

Thanks a lot for testing.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/include/asm/parport.h b/arch/sparc/include/asm/parport.h
index c333b8d..d21ad50 100644
--- a/arch/sparc/include/asm/parport.h
+++ b/arch/sparc/include/asm/parport.h
@@ -228,6 +228,10 @@  static const struct of_device_id ecpp_match[] = {
 		.name = "parallel",
 		.compatible = "ns87317-ecpp",
 	},
+	{
+		.name = "parallel",
+		.compatible = "pnpALI,1533,3",
+	},
 	{},
 };