diff mbox

[U-Boot,V2,4/6] gpio: pic32: remove gpio_xlate routine

Message ID 1460394019-3393-5-git-send-email-eric@nelint.com
State Accepted
Commit 5206e7bff575e3c0b96b8db89c80d4f020ed7539
Delegated to: Tom Rini
Headers show

Commit Message

Eric Nelson April 11, 2016, 5 p.m. UTC 
With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass,
the pic32 gpio driver doesn't need a custom xlate routine.

Signed-off-by: Eric Nelson <eric@nelint.com>
Acked-by: Simon Glass <sjg@chromium.org>
---
 V2 removes the include of <dt-bindings/gpio/gpio.h>
 drivers/gpio/pic32_gpio.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Purna Chandra Mandal April 12, 2016, 3:49 a.m. UTC | #1 
On 04/11/2016 10:30 PM, Eric Nelson wrote:

> With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass,
> the pic32 gpio driver doesn't need a custom xlate routine.
>
> Signed-off-by: Eric Nelson <eric@nelint.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Purna Chandra Mandal <purna.mandal@microchip.com>
diff mbox

Patch

diff --git a/drivers/gpio/pic32_gpio.c b/drivers/gpio/pic32_gpio.c
index 499b4fa..7a037f3 100644
--- a/drivers/gpio/pic32_gpio.c
+++ b/drivers/gpio/pic32_gpio.c
@@ -12,7 +12,6 @@ 
 #include <asm/io.h>
 #include <asm/gpio.h>
 #include <linux/compat.h>
-#include <dt-bindings/gpio/gpio.h>
 #include <mach/pic32.h>
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -99,14 +98,6 @@  static int pic32_gpio_direction_output(struct udevice *dev,
 	return 0;
 }
 
-static int pic32_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
-			    struct fdtdec_phandle_args *args)
-{
-	desc->flags = args->args[1] & GPIO_ACTIVE_LOW ? GPIOD_ACTIVE_LOW : 0;
-
-	return 0;
-}
-
 static int pic32_gpio_get_function(struct udevice *dev, unsigned offset)
 {
 	int ret = GPIOF_UNUSED;
@@ -131,7 +122,6 @@  static const struct dm_gpio_ops gpio_pic32_ops = {
 	.get_value		= pic32_gpio_get_value,
 	.set_value		= pic32_gpio_set_value,
 	.get_function		= pic32_gpio_get_function,
-	.xlate			= pic32_gpio_xlate,
 };
 
 static int pic32_gpio_probe(struct udevice *dev)