diff mbox

drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

Message ID 1460140787-12610-1-git-send-email-dvlasenk@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Denys Vlasenko April 8, 2016, 6:39 p.m. UTC
This function compiles to 895 bytes of machine code.

Clearly, this isn't a time-critical function.
For one, it has a number of udelay(1) calls.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: David S. Miller <davem@davemloft.net>
CC: linux-kernel@vger.kernel.org
CC: netdev@vger.kernel.org
---
 drivers/net/ethernet/jme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller April 14, 2016, 2:57 a.m. UTC | #1
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Fri,  8 Apr 2016 20:39:47 +0200

> This function compiles to 895 bytes of machine code.
> 
> Clearly, this isn't a time-critical function.
> For one, it has a number of udelay(1) calls.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

No x.c file should be using inline anyways, applied to net-next,
thanks a lot!
diff mbox

Patch

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 3ddf657..711cb19 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -222,7 +222,7 @@  jme_clear_ghc_reset(struct jme_adapter *jme)
 	jwrite32f(jme, JME_GHC, jme->reg_ghc);
 }
 
-static inline void
+static void
 jme_reset_mac_processor(struct jme_adapter *jme)
 {
 	static const u32 mask[WAKEUP_FRAME_MASK_DWNR] = {0, 0, 0, 0};