| Message ID | 1460091281-14664-1-git-send-email-aik@ozlabs.ru (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Fri, Apr 08, 2016 at 02:54:41PM +1000, Alexey Kardashevskiy wrote: > This removes iommu_group_get_iommudata() as the result is never used. > As this is a minor cleanup, no change in behavior is expected. > > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > --- > drivers/vfio/vfio_iommu_spapr_tce.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c > index 0582b72..6419566 100644 > --- a/drivers/vfio/vfio_iommu_spapr_tce.c > +++ b/drivers/vfio/vfio_iommu_spapr_tce.c > @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl); > static void tce_iommu_release(void *iommu_data) > { > struct tce_container *container = iommu_data; > - struct iommu_table_group *table_group; > struct tce_iommu_group *tcegrp; > long i; > > while (tce_groups_attached(container)) { > tcegrp = list_first_entry(&container->group_list, > struct tce_iommu_group, next); > - table_group = iommu_group_get_iommudata(tcegrp->grp); > tce_iommu_detach_group(iommu_data, tcegrp->grp); > } >
On Fri, 8 Apr 2016 14:54:41 +1000 Alexey Kardashevskiy <aik@ozlabs.ru> wrote: > This removes iommu_group_get_iommudata() as the result is never used. > As this is a minor cleanup, no change in behavior is expected. > > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> > --- > drivers/vfio/vfio_iommu_spapr_tce.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c > index 0582b72..6419566 100644 > --- a/drivers/vfio/vfio_iommu_spapr_tce.c > +++ b/drivers/vfio/vfio_iommu_spapr_tce.c > @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl); > static void tce_iommu_release(void *iommu_data) > { > struct tce_container *container = iommu_data; > - struct iommu_table_group *table_group; > struct tce_iommu_group *tcegrp; > long i; > > while (tce_groups_attached(container)) { > tcegrp = list_first_entry(&container->group_list, > struct tce_iommu_group, next); > - table_group = iommu_group_get_iommudata(tcegrp->grp); > tce_iommu_detach_group(iommu_data, tcegrp->grp); > } > Applied to next with David's R-b for v4.7. Thanks, Alex
diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c index 0582b72..6419566 100644 --- a/drivers/vfio/vfio_iommu_spapr_tce.c +++ b/drivers/vfio/vfio_iommu_spapr_tce.c @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl); static void tce_iommu_release(void *iommu_data) { struct tce_container *container = iommu_data; - struct iommu_table_group *table_group; struct tce_iommu_group *tcegrp; long i; while (tce_groups_attached(container)) { tcegrp = list_first_entry(&container->group_list, struct tce_iommu_group, next); - table_group = iommu_group_get_iommudata(tcegrp->grp); tce_iommu_detach_group(iommu_data, tcegrp->grp); }
This removes iommu_group_get_iommudata() as the result is never used. As this is a minor cleanup, no change in behavior is expected. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- drivers/vfio/vfio_iommu_spapr_tce.c | 2 -- 1 file changed, 2 deletions(-)