diff mbox

[U-Boot,03/11] ti_omap5_common: eth: do not define DM_ETH for spl

Message ID 1460042230-15205-4-git-send-email-mugunthanvnm@ti.com
State Accepted
Commit 3d12e804956ca996b6621cd1e04fabd39b401882
Delegated to: Joe Hershberger
Headers show

Commit Message

Mugunthan V N April 7, 2016, 3:17 p.m. UTC 
Since omap's spl doesn't support DM currently, do not define
DM_ETH for spl build.

Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
 include/configs/ti_omap5_common.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass April 9, 2016, 6:35 p.m. UTC | #1 
Hi Mugunthan,

On 7 April 2016 at 09:17, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> Since omap's spl doesn't support DM currently, do not define
> DM_ETH for spl build.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
>  include/configs/ti_omap5_common.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

I suppose this is OK as a temporary convenience, although we should
use defconfig for this sort of thing.

>
> diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h
> index 202b18c..c592646 100644
> --- a/include/configs/ti_omap5_common.h
> +++ b/include/configs/ti_omap5_common.h
> @@ -155,6 +155,7 @@
>  #ifdef CONFIG_SPL_BUILD
>  #undef CONFIG_DM_MMC
>  #undef CONFIG_TIMER
> +#undef CONFIG_DM_ETH
>  #endif
>
>  #endif /* __CONFIG_TI_OMAP5_COMMON_H */
> --
> 2.8.1.101.g72d917a
>
Mugunthan V N April 11, 2016, 5:54 a.m. UTC | #2 
On Sunday 10 April 2016 12:05 AM, Simon Glass wrote:
> Hi Mugunthan,
> 
> On 7 April 2016 at 09:17, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> Since omap's spl doesn't support DM currently, do not define
>> DM_ETH for spl build.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> ---
>>  include/configs/ti_omap5_common.h | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> I suppose this is OK as a temporary convenience, although we should
> use defconfig for this sort of thing.
> 

Yes, this is a temporary. When omap's spl updated to support DM, these
undefs has to be removed.

Regards
Mugunthan V N
Tom Rini April 11, 2016, 3:01 p.m. UTC | #3 
On Thu, Apr 07, 2016 at 08:47:02PM +0530, Mugunthan V N wrote:

> Since omap's spl doesn't support DM currently, do not define
> DM_ETH for spl build.
> 
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox

Patch

diff --git a/include/configs/ti_omap5_common.h b/include/configs/ti_omap5_common.h
index 202b18c..c592646 100644
--- a/include/configs/ti_omap5_common.h
+++ b/include/configs/ti_omap5_common.h
@@ -155,6 +155,7 @@ 
 #ifdef CONFIG_SPL_BUILD
 #undef CONFIG_DM_MMC
 #undef CONFIG_TIMER
+#undef CONFIG_DM_ETH
 #endif
 
 #endif /* __CONFIG_TI_OMAP5_COMMON_H */