Patchwork [2/3,v2] dts: Add sdhci,auto-cmd12 field for p4080 device tree

login
register
mail settings
Submitter Zang Roy-R61911
Date Aug. 3, 2010, 3:11 a.m.
Message ID <1280805072-26112-2-git-send-email-tie-fei.zang@freescale.com>
Download mbox | patch
Permalink /patch/60715/
State Accepted, archived
Delegated to: Kumar Gala
Headers show

Comments

Zang Roy-R61911 - Aug. 3, 2010, 3:11 a.m.
Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
 Documentation/powerpc/dts-bindings/fsl/esdhc.txt |    2 ++
 arch/powerpc/boot/dts/p4080ds.dts                |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)
Grant Likely - Aug. 5, 2010, 12:08 a.m.
On Mon, Aug 2, 2010 at 9:11 PM, Roy Zang <tie-fei.zang@freescale.com> wrote:
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
>  Documentation/powerpc/dts-bindings/fsl/esdhc.txt |    2 ++
>  arch/powerpc/boot/dts/p4080ds.dts                |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> index 8a00407..64bcb8b 100644
> --- a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> @@ -14,6 +14,8 @@ Required properties:
>     reports inverted write-protect state;
>   - sdhci,1-bit-only : (optional) specifies that a controller can
>     only handle 1-bit data transfers.
> +  - sdhci,auto-cmd12: (optional) specifies that a controller can
> +    only handle auto CMD12.

I read this, but I still don't understand what it means.  What does
"auto CMD12" mean?  Are there other kinds of CMD12?  Part of this
might be my ignorance about how eSDHC works, but it could be clearer.

Also, you can feel free to merge this patch with patch 1 in your
series.  I makes sense to update the documentation and the driver at
the same time.

g.
Anton Vorontsov - Aug. 9, 2010, 5:36 p.m.
On Tue, Aug 03, 2010 at 11:11:11AM +0800, Roy Zang wrote:
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
>  Documentation/powerpc/dts-bindings/fsl/esdhc.txt |    2 ++
>  arch/powerpc/boot/dts/p4080ds.dts                |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> index 8a00407..64bcb8b 100644
> --- a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
> @@ -14,6 +14,8 @@ Required properties:
>      reports inverted write-protect state;
>    - sdhci,1-bit-only : (optional) specifies that a controller can
>      only handle 1-bit data transfers.
> +  - sdhci,auto-cmd12: (optional) specifies that a controller can
> +    only handle auto CMD12.

Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>

>  Example:
>  
> diff --git a/arch/powerpc/boot/dts/p4080ds.dts b/arch/powerpc/boot/dts/p4080ds.dts
> index 6b29eab..efa0091 100644
> --- a/arch/powerpc/boot/dts/p4080ds.dts
> +++ b/arch/powerpc/boot/dts/p4080ds.dts
> @@ -280,6 +280,7 @@
>  			reg = <0x114000 0x1000>;
>  			interrupts = <48 2>;
>  			interrupt-parent = <&mpic>;
> +			sdhci,auto-cmd12;
>  		};
>  
>  		i2c@118000 {

Patch

diff --git a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
index 8a00407..64bcb8b 100644
--- a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt
@@ -14,6 +14,8 @@  Required properties:
     reports inverted write-protect state;
   - sdhci,1-bit-only : (optional) specifies that a controller can
     only handle 1-bit data transfers.
+  - sdhci,auto-cmd12: (optional) specifies that a controller can
+    only handle auto CMD12.
 
 Example:
 
diff --git a/arch/powerpc/boot/dts/p4080ds.dts b/arch/powerpc/boot/dts/p4080ds.dts
index 6b29eab..efa0091 100644
--- a/arch/powerpc/boot/dts/p4080ds.dts
+++ b/arch/powerpc/boot/dts/p4080ds.dts
@@ -280,6 +280,7 @@ 
 			reg = <0x114000 0x1000>;
 			interrupts = <48 2>;
 			interrupt-parent = <&mpic>;
+			sdhci,auto-cmd12;
 		};
 
 		i2c@118000 {