Patchwork [ARM] : Remove superfluous test in arm_override_options

login
register
mail settings
Submitter John Tytgat
Date Aug. 2, 2010, 11:06 p.m.
Message ID <0177b44051.Jo@hobbes.bass-software.com>
Download mbox | patch
Permalink /patch/60691/
State New
Headers show

Comments

John Tytgat - Aug. 2, 2010, 11:06 p.m.
arm_override_options() unnecessarily tests twice on non-Thumb +
interworking combination being selected.  Also a small indentation fix
can be done there.

gcc/

John Tytgat  <John.Tytgat@aaug.net>

	* config/arm/arm.c (arm_override_options): Remove superfluous test.
	Fix indentation.

Patch attached.  Please check in after approval.

John.
John Tytgat - Aug. 10, 2010, 11:20 p.m.
In message <0177b44051.Jo@hobbes.bass-software.com>
          John Tytgat <John.Tytgat@aaug.net> wrote:

> arm_override_options() unnecessarily tests twice on non-Thumb +
> interworking combination being selected.  Also a small indentation fix
> can be done there.
> 
> gcc/
> 
> John Tytgat  <John.Tytgat@aaug.net>
> 
> 	* config/arm/arm.c (arm_override_options): Remove superfluous test.
> 	Fix indentation.
> 
> Patch attached.  Please check in after approval.

Ping ? http://gcc.gnu.org/ml/gcc-patches/2010-08/msg00158.html

John.
John Tytgat - Aug. 19, 2010, 10:20 p.m.
In message <e572d44451.Jo@hobbes.bass-software.com>
          John Tytgat <John.Tytgat@aaug.net> wrote:

> In message <0177b44051.Jo@hobbes.bass-software.com>
>           John Tytgat <John.Tytgat@aaug.net> wrote:
> 
> > arm_override_options() unnecessarily tests twice on non-Thumb +
> > interworking combination being selected.  Also a small indentation fix
> > can be done there.
> > 
> > gcc/
> > 
> > John Tytgat  <John.Tytgat@aaug.net>
> > 
> > 	* config/arm/arm.c (arm_override_options): Remove superfluous test.
> > 	Fix indentation.
> > 
> > Patch attached.  Please check in after approval.
> 
> Ping ? http://gcc.gnu.org/ml/gcc-patches/2010-08/msg00158.html

Ping^2 ?

John.
John Tytgat - Aug. 28, 2010, 12:28 a.m.
In message <1e73714951.Jo@hobbes.bass-software.com>
          John Tytgat <John.Tytgat@aaug.net> wrote:

> In message <e572d44451.Jo@hobbes.bass-software.com>
>           John Tytgat <John.Tytgat@aaug.net> wrote:
> 
> > In message <0177b44051.Jo@hobbes.bass-software.com>
> >           John Tytgat <John.Tytgat@aaug.net> wrote:
> > 
> > > arm_override_options() unnecessarily tests twice on non-Thumb +
> > > interworking combination being selected.  Also a small indentation fix
> > > can be done there.
> > > 
> > > gcc/
> > > 
> > > John Tytgat  <John.Tytgat@aaug.net>
> > > 
> > > 	* config/arm/arm.c (arm_override_options): Remove superfluous test.
> > > 	Fix indentation.
> > > 
> > > Patch attached.  Please check in after approval.
> > 
> > Ping ? http://gcc.gnu.org/ml/gcc-patches/2010-08/msg00158.html
> 
> Ping^2 ?

Ping^3 ?
Nick Clifton - Aug. 31, 2010, 8:43 a.m.
Hi John,

> Ping^3 ?

Oops, sorry...

>>>> John Tytgat<John.Tytgat@aaug.net>
>>>>
>>>> 	* config/arm/arm.c (arm_override_options): Remove superfluous test.
>>>> 	Fix indentation.

Approved and applied.

Cheers
   Nick

Patch

Index: config/arm/arm.c
===================================================================
--- config/arm/arm.c	(revision 162830)
+++ config/arm/arm.c	(working copy)
@@ -1527,7 +1527,7 @@ 
   /* Callee super interworking implies thumb interworking.  Adding
      this to the flags here simplifies the logic elsewhere.  */
   if (TARGET_THUMB && TARGET_CALLEE_INTERWORKING)
-      target_flags |= MASK_INTERWORK;
+    target_flags |= MASK_INTERWORK;
 
   /* TARGET_BACKTRACE calls leaf_function_p, which causes a crash if done
      from here where no function is being compiled currently.  */
@@ -1537,9 +1537,6 @@ 
   if (TARGET_ARM && TARGET_CALLEE_INTERWORKING)
     warning (0, "enabling callee interworking support is only meaningful when compiling for the Thumb");
 
-  if (TARGET_ARM && TARGET_CALLER_INTERWORKING)
-    warning (0, "enabling caller interworking support is only meaningful when compiling for the Thumb");
-
   if (TARGET_APCS_STACK && !TARGET_APCS_FRAME)
     {
       warning (0, "-mapcs-stack-check incompatible with -mno-apcs-frame");