| Message ID | 1459786954-12649-6-git-send-email-wens@csie.org |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On 04/04/16 09:22, Chen-Yu Tsai wrote: > The Orange PI PC uses the H3's internal Ethernet PHY with the EMAC > Ethernet controller. > > Set a proper address for the PHY and enable the EMAC. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > > This patch depends on "ARM: dts: sun8i-h3: Add Ethernet controller device", > which uses an binding still in development. > > Do not merge. > > --- > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > index daf50b9a6657..f01e10df812a 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > @@ -102,6 +102,20 @@ > status = "okay"; > }; > > +&ephy { > + allwinner,ephy-addr = <0x1>; > +}; > + > +&emac { > + phy = <&phy1>; > + phy-mode = "mii"; > + status = "okay"; > + > + phy1: ethernet-phy@1 { > + reg = <1>; > + }; > +}; As commented in patch 1, the fact that you have to put the Ethernet PHY address twice here is not really a good thing, because they cannot be dissociated from eath other, I would rather have a standard Ethernet PHY DT node represent the desired PHY address, and have your glue/SHIM SUN8I_H3_EMAC driver scan the Device Tree to know what address to program for the Ethernet PHY.
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts index daf50b9a6657..f01e10df812a 100644 --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts @@ -102,6 +102,20 @@ status = "okay"; }; +&ephy { + allwinner,ephy-addr = <0x1>; +}; + +&emac { + phy = <&phy1>; + phy-mode = "mii"; + status = "okay"; + + phy1: ethernet-phy@1 { + reg = <1>; + }; +}; + &ir { pinctrl-names = "default"; pinctrl-0 = <&ir_pins_a>;
The Orange PI PC uses the H3's internal Ethernet PHY with the EMAC Ethernet controller. Set a proper address for the PHY and enable the EMAC. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- This patch depends on "ARM: dts: sun8i-h3: Add Ethernet controller device", which uses an binding still in development. Do not merge. --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)