[testsuite] Require int32plus and scheduling support for some tests

Submitted by Senthil Kumar Selvaraj on April 4, 2016, noon

Details

Message ID 87inzxeg7o.fsf@atmel.com
State New
Headers show

Commit Message

Senthil Kumar Selvaraj April 4, 2016, noon
Hi,

  This patch add dg-require-effective-target directives to a few tests
  that were failing unnecessarily for the AVR target.

  One of them invokes the compiler with -fschedule-insns2 - I've
  required scheduling support for that testcase. For all other tests,
  I've required int32plus - they either use bit shifts wider than
  16 bits (AVR's int size), or use int constants that are too big
  for a 16 bit int.

  If ok, could someone commit please? I don't have commit access.

Regards
Senthil

2016-04-04  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>

    * gcc.c-torture/compile/pr69102.c: Require scheduling support.
    * gcc.c-torture/compile/pr37669.c: Require >=32 bit integers.
    * gcc.c-torture/execute/bitfld-6.c: Likewise.
    * gcc.c-torture/execute/bitfld-7.c: Likewise.
    * gcc.c-torture/execute/pr38151.c: Likewise.
    * gcc.c-torture/execute/pr66556.c: Likewise.
    * gcc.c-torture/execute/pr67781.c: Likewise.
    * gcc.c-torture/execute/pr68648.c: Likewise.

Comments

Senthil Kumar Selvaraj April 13, 2016, 11:59 a.m.
Ping!

Regards
Senthil

Senthil Kumar Selvaraj writes:

> Hi,
>
>   This patch add dg-require-effective-target directives to a few tests
>   that were failing unnecessarily for the AVR target.
>
>   One of them invokes the compiler with -fschedule-insns2 - I've
>   required scheduling support for that testcase. For all other tests,
>   I've required int32plus - they either use bit shifts wider than
>   16 bits (AVR's int size), or use int constants that are too big
>   for a 16 bit int.
>
>   If ok, could someone commit please? I don't have commit access.
>
> Regards
> Senthil
>
> 2016-04-04  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
>
>     * gcc.c-torture/compile/pr69102.c: Require scheduling support.
>     * gcc.c-torture/compile/pr37669.c: Require >=32 bit integers.
>     * gcc.c-torture/execute/bitfld-6.c: Likewise.
>     * gcc.c-torture/execute/bitfld-7.c: Likewise.
>     * gcc.c-torture/execute/pr38151.c: Likewise.
>     * gcc.c-torture/execute/pr66556.c: Likewise.
>     * gcc.c-torture/execute/pr67781.c: Likewise.
>     * gcc.c-torture/execute/pr68648.c: Likewise.
>
>
> diff --git gcc/testsuite/gcc.c-torture/compile/pr37669.c gcc/testsuite/gcc.c-torture/compile/pr37669.c
> index c78243b..a2eafc7 100644
> --- gcc/testsuite/gcc.c-torture/compile/pr37669.c
> +++ gcc/testsuite/gcc.c-torture/compile/pr37669.c
> @@ -1,5 +1,6 @@
>  /* This testcase used to fail because a miscompiled execute_fold_all_builtins. */
>  /* { dg-options "-fgnu89-inline" } */
> +/* { dg-require-effective-target int32plus } */
>  
>  typedef __SIZE_TYPE__ size_t;
>  extern __inline __attribute__ ((__always_inline__)) int __attribute__
> diff --git gcc/testsuite/gcc.c-torture/compile/pr69102.c gcc/testsuite/gcc.c-torture/compile/pr69102.c
> index b1328ca..1f0cdc6 100644
> --- gcc/testsuite/gcc.c-torture/compile/pr69102.c
> +++ gcc/testsuite/gcc.c-torture/compile/pr69102.c
> @@ -1,4 +1,5 @@
>  /* { dg-options "-Og -fPIC -fschedule-insns2 -fselective-scheduling2 -fno-tree-fre --param=max-sched-extend-regions-iters=10" } */
> +/* { dg-require-effective-target scheduling } */
>  void bar (unsigned int);
>  
>  void
> diff --git gcc/testsuite/gcc.c-torture/execute/bitfld-6.c gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
> index 50927dc..b8c5cbd 100644
> --- gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
> +++ gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
>  union U
>  {
>    const int a;
> diff --git gcc/testsuite/gcc.c-torture/execute/bitfld-7.c gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
> index e9a61df..350e7a3 100644
> --- gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
> +++ gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
>  union U
>  {
>    const int a;
> diff --git gcc/testsuite/gcc.c-torture/execute/pr38151.c gcc/testsuite/gcc.c-torture/execute/pr38151.c
> index 5ee058d..86c8f77 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr38151.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr38151.c
> @@ -1,4 +1,5 @@
>  /* { dg-options "-Wno-psabi" } */
> +/* { dg-require-effective-target int32plus } */
>  void abort (void);
>  
>  struct S2848
> diff --git gcc/testsuite/gcc.c-torture/execute/pr66556.c gcc/testsuite/gcc.c-torture/execute/pr66556.c
> index f7acf1c..d1259c4 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr66556.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr66556.c
> @@ -1,4 +1,5 @@
>  /* { dg-do run } */
> +/* { dg-require-effective-target int32plus } */
>  
>  extern void abort (void);
>  
> diff --git gcc/testsuite/gcc.c-torture/execute/pr67781.c gcc/testsuite/gcc.c-torture/execute/pr67781.c
> index bf50aa2..71ccd6a 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr67781.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr67781.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
>  #ifdef __UINT32_TYPE__
>  typedef __UINT32_TYPE__ uint32_t;
>  #else
> diff --git gcc/testsuite/gcc.c-torture/execute/pr68648.c gcc/testsuite/gcc.c-torture/execute/pr68648.c
> index fc66806..db55bd0 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr68648.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr68648.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
>  int __attribute__ ((noinline))
>  foo (void)
>  {
Mike Stump April 15, 2016, 7:06 p.m.
> On Apr 4, 2016, at 5:00 AM, Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com> wrote:
>  This patch add dg-require-effective-target directives to a few tests
>  that were failing unnecessarily for the AVR target.

So the branch has been cut.  We’re now in RM only mode.  The change looks reasonably safe for the branch.  I’d propose that we put it into trunk as it opens up for such changes, let it bake there as normal, and if no down sides, then push into the release branch at that point.  I do not think we should hold or try and short circuit it faster into the next release.  This means that the change would go in, not in the first release from the branch, but post the first release.

Of course, an RM gets to make the decision at this point.

The trunk should open up in the next few days and it’s Ok there at that time.

>  One of them invokes the compiler with -fschedule-insns2 - I've
>  required scheduling support for that testcase. For all other tests,
>  I've required int32plus - they either use bit shifts wider than
>  16 bits (AVR's int size), or use int constants that are too big
>  for a 16 bit int.
> 
>  If ok, could someone commit please? I don't have commit access.
> 
> Regards
> Senthil
> 
> 2016-04-04  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
> 
>    * gcc.c-torture/compile/pr69102.c: Require scheduling support.
>    * gcc.c-torture/compile/pr37669.c: Require >=32 bit integers.
>    * gcc.c-torture/execute/bitfld-6.c: Likewise.
>    * gcc.c-torture/execute/bitfld-7.c: Likewise.
>    * gcc.c-torture/execute/pr38151.c: Likewise.
>    * gcc.c-torture/execute/pr66556.c: Likewise.
>    * gcc.c-torture/execute/pr67781.c: Likewise.
>    * gcc.c-torture/execute/pr68648.c: Likewise.
> 
> 
> diff --git gcc/testsuite/gcc.c-torture/compile/pr37669.c gcc/testsuite/gcc.c-torture/compile/pr37669.c
> index c78243b..a2eafc7 100644
> --- gcc/testsuite/gcc.c-torture/compile/pr37669.c
> +++ gcc/testsuite/gcc.c-torture/compile/pr37669.c
> @@ -1,5 +1,6 @@
> /* This testcase used to fail because a miscompiled execute_fold_all_builtins. */
> /* { dg-options "-fgnu89-inline" } */
> +/* { dg-require-effective-target int32plus } */
> 
> typedef __SIZE_TYPE__ size_t;
> extern __inline __attribute__ ((__always_inline__)) int __attribute__
> diff --git gcc/testsuite/gcc.c-torture/compile/pr69102.c gcc/testsuite/gcc.c-torture/compile/pr69102.c
> index b1328ca..1f0cdc6 100644
> --- gcc/testsuite/gcc.c-torture/compile/pr69102.c
> +++ gcc/testsuite/gcc.c-torture/compile/pr69102.c
> @@ -1,4 +1,5 @@
> /* { dg-options "-Og -fPIC -fschedule-insns2 -fselective-scheduling2 -fno-tree-fre --param=max-sched-extend-regions-iters=10" } */
> +/* { dg-require-effective-target scheduling } */
> void bar (unsigned int);
> 
> void
> diff --git gcc/testsuite/gcc.c-torture/execute/bitfld-6.c gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
> index 50927dc..b8c5cbd 100644
> --- gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
> +++ gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
> union U
> {
>   const int a;
> diff --git gcc/testsuite/gcc.c-torture/execute/bitfld-7.c gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
> index e9a61df..350e7a3 100644
> --- gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
> +++ gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
> union U
> {
>   const int a;
> diff --git gcc/testsuite/gcc.c-torture/execute/pr38151.c gcc/testsuite/gcc.c-torture/execute/pr38151.c
> index 5ee058d..86c8f77 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr38151.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr38151.c
> @@ -1,4 +1,5 @@
> /* { dg-options "-Wno-psabi" } */
> +/* { dg-require-effective-target int32plus } */
> void abort (void);
> 
> struct S2848
> diff --git gcc/testsuite/gcc.c-torture/execute/pr66556.c gcc/testsuite/gcc.c-torture/execute/pr66556.c
> index f7acf1c..d1259c4 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr66556.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr66556.c
> @@ -1,4 +1,5 @@
> /* { dg-do run } */
> +/* { dg-require-effective-target int32plus } */
> 
> extern void abort (void);
> 
> diff --git gcc/testsuite/gcc.c-torture/execute/pr67781.c gcc/testsuite/gcc.c-torture/execute/pr67781.c
> index bf50aa2..71ccd6a 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr67781.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr67781.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
> #ifdef __UINT32_TYPE__
> typedef __UINT32_TYPE__ uint32_t;
> #else
> diff --git gcc/testsuite/gcc.c-torture/execute/pr68648.c gcc/testsuite/gcc.c-torture/execute/pr68648.c
> index fc66806..db55bd0 100644
> --- gcc/testsuite/gcc.c-torture/execute/pr68648.c
> +++ gcc/testsuite/gcc.c-torture/execute/pr68648.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target int32plus } */
> int __attribute__ ((noinline))
> foo (void)
> {
Jeff Law April 26, 2016, 8:56 p.m.
On 04/04/2016 06:00 AM, Senthil Kumar Selvaraj wrote:
> 2016-04-04  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
>
>     * gcc.c-torture/compile/pr69102.c: Require scheduling support.
>     * gcc.c-torture/compile/pr37669.c: Require >=32 bit integers.
>     * gcc.c-torture/execute/bitfld-6.c: Likewise.
>     * gcc.c-torture/execute/bitfld-7.c: Likewise.
>     * gcc.c-torture/execute/pr38151.c: Likewise.
>     * gcc.c-torture/execute/pr66556.c: Likewise.
>     * gcc.c-torture/execute/pr67781.c: Likewise.
>     * gcc.c-torture/execute/pr68648.c: Likewise.
>
Thanks.  Committed to the trunk.

jeff

Patch hide | download patch | download mbox

diff --git gcc/testsuite/gcc.c-torture/compile/pr37669.c gcc/testsuite/gcc.c-torture/compile/pr37669.c
index c78243b..a2eafc7 100644
--- gcc/testsuite/gcc.c-torture/compile/pr37669.c
+++ gcc/testsuite/gcc.c-torture/compile/pr37669.c
@@ -1,5 +1,6 @@ 
 /* This testcase used to fail because a miscompiled execute_fold_all_builtins. */
 /* { dg-options "-fgnu89-inline" } */
+/* { dg-require-effective-target int32plus } */
 
 typedef __SIZE_TYPE__ size_t;
 extern __inline __attribute__ ((__always_inline__)) int __attribute__
diff --git gcc/testsuite/gcc.c-torture/compile/pr69102.c gcc/testsuite/gcc.c-torture/compile/pr69102.c
index b1328ca..1f0cdc6 100644
--- gcc/testsuite/gcc.c-torture/compile/pr69102.c
+++ gcc/testsuite/gcc.c-torture/compile/pr69102.c
@@ -1,4 +1,5 @@ 
 /* { dg-options "-Og -fPIC -fschedule-insns2 -fselective-scheduling2 -fno-tree-fre --param=max-sched-extend-regions-iters=10" } */
+/* { dg-require-effective-target scheduling } */
 void bar (unsigned int);
 
 void
diff --git gcc/testsuite/gcc.c-torture/execute/bitfld-6.c gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
index 50927dc..b8c5cbd 100644
--- gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
+++ gcc/testsuite/gcc.c-torture/execute/bitfld-6.c
@@ -1,3 +1,4 @@ 
+/* { dg-require-effective-target int32plus } */
 union U
 {
   const int a;
diff --git gcc/testsuite/gcc.c-torture/execute/bitfld-7.c gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
index e9a61df..350e7a3 100644
--- gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
+++ gcc/testsuite/gcc.c-torture/execute/bitfld-7.c
@@ -1,3 +1,4 @@ 
+/* { dg-require-effective-target int32plus } */
 union U
 {
   const int a;
diff --git gcc/testsuite/gcc.c-torture/execute/pr38151.c gcc/testsuite/gcc.c-torture/execute/pr38151.c
index 5ee058d..86c8f77 100644
--- gcc/testsuite/gcc.c-torture/execute/pr38151.c
+++ gcc/testsuite/gcc.c-torture/execute/pr38151.c
@@ -1,4 +1,5 @@ 
 /* { dg-options "-Wno-psabi" } */
+/* { dg-require-effective-target int32plus } */
 void abort (void);
 
 struct S2848
diff --git gcc/testsuite/gcc.c-torture/execute/pr66556.c gcc/testsuite/gcc.c-torture/execute/pr66556.c
index f7acf1c..d1259c4 100644
--- gcc/testsuite/gcc.c-torture/execute/pr66556.c
+++ gcc/testsuite/gcc.c-torture/execute/pr66556.c
@@ -1,4 +1,5 @@ 
 /* { dg-do run } */
+/* { dg-require-effective-target int32plus } */
 
 extern void abort (void);
 
diff --git gcc/testsuite/gcc.c-torture/execute/pr67781.c gcc/testsuite/gcc.c-torture/execute/pr67781.c
index bf50aa2..71ccd6a 100644
--- gcc/testsuite/gcc.c-torture/execute/pr67781.c
+++ gcc/testsuite/gcc.c-torture/execute/pr67781.c
@@ -1,3 +1,4 @@ 
+/* { dg-require-effective-target int32plus } */
 #ifdef __UINT32_TYPE__
 typedef __UINT32_TYPE__ uint32_t;
 #else
diff --git gcc/testsuite/gcc.c-torture/execute/pr68648.c gcc/testsuite/gcc.c-torture/execute/pr68648.c
index fc66806..db55bd0 100644
--- gcc/testsuite/gcc.c-torture/execute/pr68648.c
+++ gcc/testsuite/gcc.c-torture/execute/pr68648.c
@@ -1,3 +1,4 @@ 
+/* { dg-require-effective-target int32plus } */
 int __attribute__ ((noinline))
 foo (void)
 {