| Message ID | 1459771085-5951-4-git-send-email-mugunthanvnm@ti.com |
|---|---|
| State | Accepted |
| Commit | e36142143005e86d2d083d9549836c32bb3a6120 |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Apr 04, 2016 at 05:28:03PM +0530, Mugunthan V N wrote: > As per mmc device tree binding documentation card detect gpio has > to be active low signal. When a hardware is designed with active > high card detect, gpio polarity has to be changed with > cd-inverted dt property. > > In DRA72x and AM57xx EVMs the card detect gpio is designed as > active low gpio. So correcting the dt card detect gpio > definition. > > Also adding card-detect gpio for DRA74x EVM. > > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Mon, Apr 04, 2016 at 05:28:03PM +0530, Mugunthan V N wrote: > As per mmc device tree binding documentation card detect gpio has > to be active low signal. When a hardware is designed with active > high card detect, gpio polarity has to be changed with > cd-inverted dt property. > > In DRA72x and AM57xx EVMs the card detect gpio is designed as > active low gpio. So correcting the dt card detect gpio > definition. > > Also adding card-detect gpio for DRA74x EVM. > > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/dts/am57xx-beagle-x15.dts b/arch/arm/dts/am57xx-beagle-x15.dts index e424562..38b266a 100644 --- a/arch/arm/dts/am57xx-beagle-x15.dts +++ b/arch/arm/dts/am57xx-beagle-x15.dts @@ -586,7 +586,7 @@ vmmc_aux-supply = <&vdd_3v3>; pbias-supply = <&pbias_mmc_reg>; bus-width = <4>; - cd-gpios = <&gpio6 27 0>; /* gpio 219 */ + cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; /* gpio 219 */ }; &mmc2 { diff --git a/arch/arm/dts/dra7-evm.dts b/arch/arm/dts/dra7-evm.dts index 242fd53..08ef04e 100644 --- a/arch/arm/dts/dra7-evm.dts +++ b/arch/arm/dts/dra7-evm.dts @@ -469,6 +469,11 @@ status = "okay"; vmmc-supply = <&ldo1_reg>; bus-width = <4>; + /* + * SDCD signal is not being used here - using the fact that GPIO mode + * is always hardwired. + */ + cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; }; &mmc2 { diff --git a/arch/arm/dts/dra72-evm.dts b/arch/arm/dts/dra72-evm.dts index fc2d167..205103e 100644 --- a/arch/arm/dts/dra72-evm.dts +++ b/arch/arm/dts/dra72-evm.dts @@ -503,7 +503,7 @@ * SDCD signal is not being used here - using the fact that GPIO mode * is a viable alternative */ - cd-gpios = <&gpio6 27 0>; + cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; }; &mmc2 {
As per mmc device tree binding documentation card detect gpio has to be active low signal. When a hardware is designed with active high card detect, gpio polarity has to be changed with cd-inverted dt property. In DRA72x and AM57xx EVMs the card detect gpio is designed as active low gpio. So correcting the dt card detect gpio definition. Also adding card-detect gpio for DRA74x EVM. Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> --- arch/arm/dts/am57xx-beagle-x15.dts | 2 +- arch/arm/dts/dra7-evm.dts | 5 +++++ arch/arm/dts/dra72-evm.dts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-)