From patchwork Mon Aug 2 08:52:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 60522 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E803C1007FD for ; Mon, 2 Aug 2010 18:52:49 +1000 (EST) Received: (qmail 18890 invoked by alias); 2 Aug 2010 08:52:46 -0000 Received: (qmail 18880 invoked by uid 22791); 2 Aug 2010 08:52:46 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL, BAYES_50, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Aug 2010 08:52:39 +0000 Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id o728qQF9011442 for ; Mon, 2 Aug 2010 09:52:26 +0100 (BST) Received: from [10.1.66.29] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Mon, 2 Aug 2010 09:52:35 +0100 Subject: [Patch ARM] committed - Remove superfluous definition of COSTS_N_INSNS in the ARM backend. From: Ramana Radhakrishnan Reply-To: ramana.radhakrishnan@arm.com To: gcc-patches@gcc.gnu.org Date: Mon, 02 Aug 2010 09:52:34 +0100 Message-Id: <1280739154.9309.7.camel@e102325-lin.cambridge.arm.com> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, This removes a superfluous definition of COSTS_N_INSNS in the ARM backend. This bit of code dates back to 2000 when the ARM and Thumb backends were merged but wasn't removed when the definition of COSTS_N_INSNS was moved to rtl.h in Sept. 2000. I can't see how this definition could have been exercised in the last few years and hence committed as obvious. cheers Ramana 2010-08-02 Ramana Radhakrishnan * config/arm/arm.c (COSTS_N_INSNS): Remove definition. Index: config/arm/arm.c =================================================================== --- config/arm/arm.c (revision 162810) +++ config/arm/arm.c (working copy) @@ -6293,9 +6293,6 @@ arm_cannot_force_const_mem (rtx x) #define REG_OR_SUBREG_RTX(X) \ (GET_CODE (X) == REG ? (X) : SUBREG_REG (X)) -#ifndef COSTS_N_INSNS -#define COSTS_N_INSNS(N) ((N) * 4 - 2) -#endif static inline int thumb1_rtx_costs (rtx x, enum rtx_code code, enum rtx_code outer) {