Patchwork tc: make symbols loaded from tc action modules global.

login
register
mail settings
Submitter Andreas Henriksson
Date Aug. 2, 2010, 7:30 a.m.
Message ID <20100802073032.GA32046@amd64.fatal.se>
Download mbox | patch
Permalink /patch/60512/
State Accepted
Delegated to: stephen hemminger
Headers show

Comments

Andreas Henriksson - Aug. 2, 2010, 7:30 a.m.
Fixes problems with xtables based MARK target ("ipt" module).
When tc loads the "ipt" (xt) module it kept the symbols local,
this made loading of libxtables not find the required struct.

currently ipt/xt is the only tc action module.
iproute2 never seem to do dlclose.
hopefully the modules doesn't export more symbols then needed.

In this situation hopefully the RTLD_GLOBAL flag won't hurt us.

I've been using this patch in the Debian package of iproute for
the last 3 weeks and noone has complained.
( This fixes http://bugs.debian.org/584898 )

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
 tc/m_action.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
stephen hemminger - Aug. 2, 2010, 4:55 p.m.
On Mon, 2 Aug 2010 09:30:33 +0200
Andreas Henriksson <andreas@fatal.se> wrote:

> Fixes problems with xtables based MARK target ("ipt" module).
> When tc loads the "ipt" (xt) module it kept the symbols local,
> this made loading of libxtables not find the required struct.
> 
> currently ipt/xt is the only tc action module.
> iproute2 never seem to do dlclose.
> hopefully the modules doesn't export more symbols then needed.
> 
> In this situation hopefully the RTLD_GLOBAL flag won't hurt us.
> 
> I've been using this patch in the Debian package of iproute for
> the last 3 weeks and noone has complained.
> ( This fixes http://bugs.debian.org/584898 )
> 
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
> ---
>  tc/m_action.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tc/m_action.c b/tc/m_action.c
> index a198158..6464b2e 100644
> --- a/tc/m_action.c
> +++ b/tc/m_action.c
> @@ -99,7 +99,7 @@ restart_s:
>  	}
>  
>  	snprintf(buf, sizeof(buf), "%s/m_%s.so", get_tc_lib(), str);
> -	dlh = dlopen(buf, RTLD_LAZY);
> +	dlh = dlopen(buf, RTLD_LAZY | RTLD_GLOBAL);
>  	if (dlh == NULL) {
>  		dlh = aBODY;
>  		if (dlh == NULL) {


Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/tc/m_action.c b/tc/m_action.c
index a198158..6464b2e 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -99,7 +99,7 @@  restart_s:
 	}
 
 	snprintf(buf, sizeof(buf), "%s/m_%s.so", get_tc_lib(), str);
-	dlh = dlopen(buf, RTLD_LAZY);
+	dlh = dlopen(buf, RTLD_LAZY | RTLD_GLOBAL);
 	if (dlh == NULL) {
 		dlh = aBODY;
 		if (dlh == NULL) {