diff mbox

[U-Boot,2/7] gpio: intel_broadwell: remove gpio_xlate routine

Message ID 1459525662-28032-3-git-send-email-eric@nelint.com
State Accepted
Commit 8376aaddaf29b5ec296759f2b374cf940b932962
Delegated to: Simon Glass
Headers show

Commit Message

Eric Nelson April 1, 2016, 3:47 p.m. UTC 
With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass,
the intel_broadwell driver doesn't need a custom xlate routine.

Signed-off-by: Eric Nelson <eric@nelint.com>
---
 drivers/gpio/intel_broadwell_gpio.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Simon Glass April 9, 2016, 6:33 p.m. UTC | #1 
On 1 April 2016 at 09:47, Eric Nelson <eric@nelint.com> wrote:
> With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass,
> the intel_broadwell driver doesn't need a custom xlate routine.
>
> Signed-off-by: Eric Nelson <eric@nelint.com>
> ---
>  drivers/gpio/intel_broadwell_gpio.c | 10 ----------
>  1 file changed, 10 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/drivers/gpio/intel_broadwell_gpio.c b/drivers/gpio/intel_broadwell_gpio.c
index 8cf76f9..81ce446 100644
--- a/drivers/gpio/intel_broadwell_gpio.c
+++ b/drivers/gpio/intel_broadwell_gpio.c
@@ -162,15 +162,6 @@  static int broadwell_gpio_ofdata_to_platdata(struct udevice *dev)
 	return 0;
 }
 
-static int broadwell_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
-				struct fdtdec_phandle_args *args)
-{
-	desc->offset = args->args[0];
-	desc->flags = args->args[1] & GPIO_ACTIVE_LOW ? GPIOD_ACTIVE_LOW : 0;
-
-	return 0;
-}
-
 static const struct dm_gpio_ops gpio_broadwell_ops = {
 	.request		= broadwell_gpio_request,
 	.direction_input	= broadwell_gpio_direction_input,
@@ -178,7 +169,6 @@  static const struct dm_gpio_ops gpio_broadwell_ops = {
 	.get_value		= broadwell_gpio_get_value,
 	.set_value		= broadwell_gpio_set_value,
 	.get_function		= broadwell_gpio_get_function,
-	.xlate			= broadwell_gpio_xlate,
 };
 
 static const struct udevice_id intel_broadwell_gpio_ids[] = {