From patchwork Sun Aug 1 10:23:02 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 60470 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6703E1007D1 for ; Mon, 2 Aug 2010 03:17:29 +1000 (EST) Received: from localhost ([127.0.0.1]:52628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfcAA-0005gY-7c for incoming@patchwork.ozlabs.org; Sun, 01 Aug 2010 13:17:26 -0400 Received: from [140.186.70.92] (port=49922 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfbTs-0002Oc-N6 for qemu-devel@nongnu.org; Sun, 01 Aug 2010 12:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfVhL-00026N-Su for qemu-devel@nongnu.org; Sun, 01 Aug 2010 06:23:17 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:52288) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfVhL-00025D-EO for qemu-devel@nongnu.org; Sun, 01 Aug 2010 06:23:15 -0400 Received: from flocke.weilnetz.de (p54ADA754.dip.t-dialin.net [84.173.167.84]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0Lm8VZ-1PEZOi3dnV-00a2P1; Sun, 01 Aug 2010 12:23:06 +0200 Received: from stefan by flocke.weilnetz.de with local (Exim 4.72) (envelope-from ) id 1OfVhA-00015g-Op; Sun, 01 Aug 2010 12:23:04 +0200 From: Stefan Weil To: QEMU Developers Date: Sun, 1 Aug 2010 12:23:02 +0200 Message-Id: <1280658182-4165-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.1 X-Provags-ID: V02:K0:fSwwLx+Dh/AjrLjPMbr3QSkZaBUIuEofWjeqPFQNTwe pzwcrwgmtJSzOrDQrsum962jUVuvNNigvWmAbKOZnUSqKfFFut 4V0GsrU23wvKmDdlsMMKUhW+i9I0EzprSmSXQUjCv6RLSZpX2M bOtE3mRa8qtwn45a2suruJYflcT/N6WvPyenV8VcrMo85aWou1 ZBoA70FsftGUbTCdjVfQJnLam8UuubpG2zFmM6q7rHPKn1SSgx 2D+kUm+WTSYJP X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Anthony Liguori , Markus Armbruster Subject: [Qemu-devel] [PATCH] qemu-option: Include name of invalid parameter in error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org All other error messages in qemu-option.c display the name of the invalid parameter. This seems to be reasonable for invalid identifiers, too. Without it, a debugger is needed to find the name. Cc: Markus Armbruster Cc: Anthony Liguori Signed-off-by: Stefan Weil --- qemu-option.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 1f8f41a..ccea267 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -694,7 +694,7 @@ QemuOpts *qemu_opts_create(QemuOptsList *list, const char *id, int fail_if_exist if (id) { if (!id_wellformed(id)) { - qerror_report(QERR_INVALID_PARAMETER_VALUE, "id", "an identifier"); + qerror_report(QERR_INVALID_PARAMETER_VALUE, id, "an identifier"); error_printf_unless_qmp("Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.\n"); return NULL; }