| Message ID | 1280594039-3246-1-git-send-email-segooon@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, 2010-07-31 at 18:33 +0200, ext Kulikov Vasiliy wrote: > wl1271_dump() uses cmd after kfree(cmd). Move kfree() just after > wl1271_dump(). > > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> > --- > drivers/net/wireless/wl12xx/wl1271_spi.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c > index 96d25fb..4cb99c5 100644 > --- a/drivers/net/wireless/wl12xx/wl1271_spi.c > +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c > @@ -160,9 +160,8 @@ static void wl1271_spi_init(struct wl1271 *wl) > spi_message_add_tail(&t, &m); > > spi_sync(wl_to_spi(wl), &m); > - kfree(cmd); > - > wl1271_dump(DEBUG_SPI, "spi init -> ", cmd, WSPI_INIT_CMD_LEN); > + kfree(cmd); > } > > #define WL1271_BUSY_WORD_TIMEOUT 1000 Whoops ;) Good catch, thanks. Acked-by: Juuso Oikarinen <juuso.oikarinen@nokia.com> -Juuso -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/wl12xx/wl1271_spi.c b/drivers/net/wireless/wl12xx/wl1271_spi.c index 96d25fb..4cb99c5 100644 --- a/drivers/net/wireless/wl12xx/wl1271_spi.c +++ b/drivers/net/wireless/wl12xx/wl1271_spi.c @@ -160,9 +160,8 @@ static void wl1271_spi_init(struct wl1271 *wl) spi_message_add_tail(&t, &m); spi_sync(wl_to_spi(wl), &m); - kfree(cmd); - wl1271_dump(DEBUG_SPI, "spi init -> ", cmd, WSPI_INIT_CMD_LEN); + kfree(cmd); } #define WL1271_BUSY_WORD_TIMEOUT 1000
wl1271_dump() uses cmd after kfree(cmd). Move kfree() just after wl1271_dump(). Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- drivers/net/wireless/wl12xx/wl1271_spi.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)