diff mbox

[v1] net: fix missing include of qapi/error.h in netmap.c

Message ID 1459429690-6144-1-git-send-email-berrange@redhat.com
State New
Headers show

Commit Message

Daniel P. Berrangé March 31, 2016, 1:08 p.m. UTC
The netmap.c file fails to build on FreeBSD with

net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
     error_setg_errno(errp, errno, "Failed to nm_open() %s",
     ^
net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
     error_propagate(errp, err);
     ^

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 net/netmap.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Blake March 31, 2016, 4:19 p.m. UTC | #1
On 03/31/2016 07:08 AM, Daniel P. Berrange wrote:
> The netmap.c file fails to build on FreeBSD with
> 
> net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
>      error_setg_errno(errp, errno, "Failed to nm_open() %s",
>      ^
> net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
>      error_propagate(errp, err);
>      ^
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  net/netmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>
Peter Maydell April 4, 2016, 2:54 p.m. UTC | #2
On 31 March 2016 at 14:08, Daniel P. Berrange <berrange@redhat.com> wrote:
> The netmap.c file fails to build on FreeBSD with
>
> net/netmap.c:95:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration]
>      error_setg_errno(errp, errno, "Failed to nm_open() %s",
>      ^
> net/netmap.c:432:9: warning: implicit declaration of function 'error_propagate' is invalid in C99 [-Wimplicit-function-declaration]
>      error_propagate(errp, err);
>      ^
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  net/netmap.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- PMM
diff mbox

Patch

diff --git a/net/netmap.c b/net/netmap.c
index d9c21b2..6cc0db5 100644
--- a/net/netmap.c
+++ b/net/netmap.c
@@ -36,6 +36,7 @@ 
 #include "clients.h"
 #include "sysemu/sysemu.h"
 #include "qemu/error-report.h"
+#include "qapi/error.h"
 #include "qemu/iov.h"
 #include "qemu/cutils.h"