diff mbox

[U-Boot] net: zynq_gem: Return error incase of invalid phy address

Message ID 25b25fa2544a73edec8baba90aba68d1fae8665f.1459414189.git.michal.simek@xilinx.com
State Accepted
Commit e76d2dcaeb9fe3d0d6f5105de518178b45423842
Delegated to: Michal Simek
Headers show

Commit Message

Michal Simek March 31, 2016, 8:49 a.m. UTC 
From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Return error from probe in case of invalid phy address.
This fixes the issue of uboot crash if phy is not detected.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/zynq_gem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Joe Hershberger April 25, 2016, 10:16 p.m. UTC | #1 
On Thu, Mar 31, 2016 at 3:49 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> Return error from probe in case of invalid phy address.
> This fixes the issue of uboot crash if phy is not detected.
>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox

Patch

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 103ed6169c0f..52a8f2760012 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -638,9 +638,7 @@  static int zynq_gem_probe(struct udevice *dev)
 	if (ret)
 		return ret;
 
-	zynq_phy_init(dev);
-
-	return 0;
+	return zynq_phy_init(dev);
 }
 
 static int zynq_gem_remove(struct udevice *dev)