From patchwork Fri Jul 30 17:51:29 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gregkh@suse.de X-Patchwork-Id: 60375 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 83CBEB6F10 for ; Sat, 31 Jul 2010 04:28:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933193Ab0G3S2R (ORCPT ); Fri, 30 Jul 2010 14:28:17 -0400 Received: from kroah.org ([198.145.64.141]:58245 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759925Ab0G3RzV (ORCPT ); Fri, 30 Jul 2010 13:55:21 -0400 Received: from localhost (c-24-16-163-131.hsd1.wa.comcast.net [24.16.163.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id AD5FF490B4; Fri, 30 Jul 2010 10:55:20 -0700 (PDT) X-Mailbox-Line: From gregkh@clark.site Fri Jul 30 10:51:40 2010 Message-Id: <20100730175140.180788935@clark.site> User-Agent: quilt/0.48-11.2 Date: Fri, 30 Jul 2010 10:51:29 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, Emil S Tantilov , "David S. Miller" , Greg KH Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, NetDev , , Stephen Hemminger Subject: [072/205] IPv6: only notify protocols if address is completely gone In-Reply-To: <20100730175238.GA3924@kroah.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2.6.34-stable review patch. If anyone has any objections, please let us know. ------------------ From: Stephen Hemminger (cherry picked from commit 8595805aafc8b077e01804c9a3668e9aa3510e89) The notifier for address down should only be called if address is completely gone, not just being marked as tentative on link transition. The code in net-next would case bonding/sctp/s390 to see address disappear on link down, but they would never see it reappear on link up. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/addrconf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2729,7 +2729,9 @@ static int addrconf_ifdown(struct net_de write_unlock_bh(&idev->lock); __ipv6_ifa_notify(RTM_DELADDR, ifa); - atomic_notifier_call_chain(&inet6addr_chain, NETDEV_DOWN, ifa); + if (ifa->dead) + atomic_notifier_call_chain(&inet6addr_chain, + NETDEV_DOWN, ifa); in6_ifa_put(ifa); write_lock_bh(&idev->lock);