diff mbox

[v4,2/3] python-pexpect: new package

Message ID 1459042284-6684-3-git-send-email-viktorin@rehivetech.com
State Accepted
Headers show

Commit Message

Jan Viktorin March 27, 2016, 1:31 a.m. UTC 
v4
* source https://pypi.python.org/pypi/pexpect
* added hash file

Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
---
 package/Config.in                          |  1 +
 package/python-pexpect/Config.in           | 11 +++++++++++
 package/python-pexpect/python-pexpect.hash |  4 ++++
 package/python-pexpect/python-pexpect.mk   | 15 +++++++++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 package/python-pexpect/Config.in
 create mode 100644 package/python-pexpect/python-pexpect.hash
 create mode 100644 package/python-pexpect/python-pexpect.mk

Comments

Jan Viktorin March 27, 2016, 1:50 a.m. UTC | #1 
On Sun, 27 Mar 2016 03:31:23 +0200
Jan Viktorin <viktorin@rehivetech.com> wrote:

> v4
> * source https://pypi.python.org/pypi/pexpect
> * added hash file
> 
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---

[...]

> diff --git a/package/python-pexpect/python-pexpect.hash b/package/python-pexpect/python-pexpect.hash
> new file mode 100644
> index 0000000..0d1e1fe
> --- /dev/null
> +++ b/package/python-pexpect/python-pexpect.hash
> @@ -0,0 +1,4 @@
> +# got from https://pypi.python.org
> +md5sum	056df81e6ca7081f1015b4b147b977b7
> +# computed manually:
> +sha256sum 232795ebcaaf2e120396dbbaa3a129eda51757eeaae1911558f4ef8ee414fc6c  pexpect-4.0.1.tar.gz

Should be md5 and sha256 (without sum)...

> diff --git a/package/python-pexpect/python-pexpect.mk b/package/python-pexpect/python-pexpect.mk
> new file mode 100644
> index 0000000..8b2809b
> --- /dev/null
> +++ b/package/python-pexpect/python-pexpect.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# python-pexpect
> +#
> +################################################################################
> +
> +PYTHON_PEXPECT_VERSION = 4.0.1
> +PYTHON_PEXPECT_SITE = https://pypi.python.org/pypi/pexpect

The URL should be https://pypi.python.org/packages/source/p/pexpect.

> +PYTHON_PEXPECT_SOURCE = pexpect-$(PYTHON_PEXPECT_VERSION).tar.gz
> +PYTHON_PEXPECT_LICENSE = ISC
> +PYTHON_PEXPECT_LICENSE_FILES = LICENSE
> +PYTHON_PEXPECT_SETUP_TYPE = distutils
> +PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess
> +
> +$(eval $(python-package))
Yegor Yefremov March 27, 2016, 8:51 p.m. UTC | #2 
On Sun, Mar 27, 2016 at 3:50 AM, Jan Viktorin <viktorin@rehivetech.com> wrote:
> On Sun, 27 Mar 2016 03:31:23 +0200
> Jan Viktorin <viktorin@rehivetech.com> wrote:
>
>> v4
>> * source https://pypi.python.org/pypi/pexpect
>> * added hash file
>>
>> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
>> ---
>
> [...]
>
>> diff --git a/package/python-pexpect/python-pexpect.hash b/package/python-pexpect/python-pexpect.hash
>> new file mode 100644
>> index 0000000..0d1e1fe
>> --- /dev/null
>> +++ b/package/python-pexpect/python-pexpect.hash
>> @@ -0,0 +1,4 @@
>> +# got from https://pypi.python.org
>> +md5sum       056df81e6ca7081f1015b4b147b977b7
>> +# computed manually:
>> +sha256sum 232795ebcaaf2e120396dbbaa3a129eda51757eeaae1911558f4ef8ee414fc6c  pexpect-4.0.1.tar.gz
>
> Should be md5 and sha256 (without sum)...
>
>> diff --git a/package/python-pexpect/python-pexpect.mk b/package/python-pexpect/python-pexpect.mk
>> new file mode 100644
>> index 0000000..8b2809b
>> --- /dev/null
>> +++ b/package/python-pexpect/python-pexpect.mk
>> @@ -0,0 +1,15 @@
>> +################################################################################
>> +#
>> +# python-pexpect
>> +#
>> +################################################################################
>> +
>> +PYTHON_PEXPECT_VERSION = 4.0.1
>> +PYTHON_PEXPECT_SITE = https://pypi.python.org/pypi/pexpect
>
> The URL should be https://pypi.python.org/packages/source/p/pexpect.
>
>> +PYTHON_PEXPECT_SOURCE = pexpect-$(PYTHON_PEXPECT_VERSION).tar.gz
>> +PYTHON_PEXPECT_LICENSE = ISC
>> +PYTHON_PEXPECT_LICENSE_FILES = LICENSE
>> +PYTHON_PEXPECT_SETUP_TYPE = distutils
>> +PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess

drop this build-time dependency

Resend v5 with all fixes and add my

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

to both python patches.

Thanks.

Yegor

>> +
>> +$(eval $(python-package))
Thomas Petazzoni April 15, 2016, 8:49 p.m. UTC | #3 
Hello,

On Sun, 27 Mar 2016 03:31:23 +0200, Jan Viktorin wrote:
> v4
> * source https://pypi.python.org/pypi/pexpect
> * added hash file

The changelog should not be part of the commit, but should be ...

> 
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---

... here.


> diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
> new file mode 100644
> index 0000000..4d04c01
> --- /dev/null
> +++ b/package/python-pexpect/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_PEXPECT
> +	bool "python-pexpect"
> +	select BR2_PACKAGE_PYTHON_PTYPROCESS
> +	help
> +	  Pexpect is a pure Python module for spawning child applications;
> +	  controlling them; and responding to expected patterns in their
> +	  output. Pexpect works like Don Libes’ Expect. Pexpect allows your
> +	  script to spawn a child application and control it as if a human
> +	  were typing commands.

Same thing: lines slightly too long.

> diff --git a/package/python-pexpect/python-pexpect.hash b/package/python-pexpect/python-pexpect.hash
> new file mode 100644
> index 0000000..0d1e1fe
> --- /dev/null
> +++ b/package/python-pexpect/python-pexpect.hash
> @@ -0,0 +1,4 @@
> +# got from https://pypi.python.org
> +md5sum	056df81e6ca7081f1015b4b147b977b7

Not even a file name here.

> +# computed manually:
> +sha256sum 232795ebcaaf2e120396dbbaa3a129eda51757eeaae1911558f4ef8ee414fc6c  pexpect-4.0.1.tar.gz

I've fixed up the hash file.

> +PYTHON_PEXPECT_VERSION = 4.0.1
> +PYTHON_PEXPECT_SITE = https://pypi.python.org/pypi/pexpect

And the _SITE variable.

> +PYTHON_PEXPECT_SOURCE = pexpect-$(PYTHON_PEXPECT_VERSION).tar.gz
> +PYTHON_PEXPECT_LICENSE = ISC
> +PYTHON_PEXPECT_LICENSE_FILES = LICENSE
> +PYTHON_PEXPECT_SETUP_TYPE = distutils
> +PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess

And removed this dependency: it's only a run-time dependency, so it
only needs to be in the Config.in file.

Applied with those issues fixed, thanks!

Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index fda5231..1c995ca 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -686,6 +686,7 @@  menu "External python modules"
 	source "package/python-paho-mqtt/Config.in"
 	source "package/python-pam/Config.in"
 	source "package/python-paramiko/Config.in"
+	source "package/python-pexpect/Config.in"
 	source "package/python-posix-ipc/Config.in"
 	source "package/python-protobuf/Config.in"
 	source "package/python-psutil/Config.in"
diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
new file mode 100644
index 0000000..4d04c01
--- /dev/null
+++ b/package/python-pexpect/Config.in
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_PYTHON_PEXPECT
+	bool "python-pexpect"
+	select BR2_PACKAGE_PYTHON_PTYPROCESS
+	help
+	  Pexpect is a pure Python module for spawning child applications;
+	  controlling them; and responding to expected patterns in their
+	  output. Pexpect works like Don Libes’ Expect. Pexpect allows your
+	  script to spawn a child application and control it as if a human
+	  were typing commands.
+
+	  https://pexpect.readthedocs.org
diff --git a/package/python-pexpect/python-pexpect.hash b/package/python-pexpect/python-pexpect.hash
new file mode 100644
index 0000000..0d1e1fe
--- /dev/null
+++ b/package/python-pexpect/python-pexpect.hash
@@ -0,0 +1,4 @@ 
+# got from https://pypi.python.org
+md5sum	056df81e6ca7081f1015b4b147b977b7
+# computed manually:
+sha256sum 232795ebcaaf2e120396dbbaa3a129eda51757eeaae1911558f4ef8ee414fc6c  pexpect-4.0.1.tar.gz
diff --git a/package/python-pexpect/python-pexpect.mk b/package/python-pexpect/python-pexpect.mk
new file mode 100644
index 0000000..8b2809b
--- /dev/null
+++ b/package/python-pexpect/python-pexpect.mk
@@ -0,0 +1,15 @@ 
+################################################################################
+#
+# python-pexpect
+#
+################################################################################
+
+PYTHON_PEXPECT_VERSION = 4.0.1
+PYTHON_PEXPECT_SITE = https://pypi.python.org/pypi/pexpect
+PYTHON_PEXPECT_SOURCE = pexpect-$(PYTHON_PEXPECT_VERSION).tar.gz
+PYTHON_PEXPECT_LICENSE = ISC
+PYTHON_PEXPECT_LICENSE_FILES = LICENSE
+PYTHON_PEXPECT_SETUP_TYPE = distutils
+PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess
+
+$(eval $(python-package))