diff mbox

[U-Boot] armv8: ls1043aqds: make sure fixed-link property is big endian

Message ID 1458877011-47300-1-git-send-email-shh.xie@gmail.com
State Accepted
Commit ce96ba4b84ceec7d0d3ed3318d25d7f1286a5535
Delegated to: York Sun
Headers show

Commit Message

shaohui xie March 25, 2016, 3:36 a.m. UTC 
From: Shaohui Xie <Shaohui.Xie@nxp.com>

When setting fixed-link property to DTS, the values should be converted
with using cpu_to_fdt32 so that to have correct value on little endian
Soc.

Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
---
 board/freescale/ls1043aqds/eth.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

York Sun April 6, 2016, 5:25 p.m. UTC | #1 
On 03/24/2016 08:46 PM, shh.xie@gmail.com wrote:
> From: Shaohui Xie <Shaohui.Xie@nxp.com>
> 
> When setting fixed-link property to DTS, the values should be converted
> with using cpu_to_fdt32 so that to have correct value on little endian
> Soc.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
> ---
>  board/freescale/ls1043aqds/eth.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Applied to u-boot-fsl-qoriq master. Awaiting upstream.
Thanks.

York
diff mbox

Patch

diff --git a/board/freescale/ls1043aqds/eth.c b/board/freescale/ls1043aqds/eth.c
index 67b4afe..bf26376 100644
--- a/board/freescale/ls1043aqds/eth.c
+++ b/board/freescale/ls1043aqds/eth.c
@@ -176,9 +176,9 @@  void board_ft_fman_fixup_port(void *fdt, char *compat, phys_addr_t addr,
 	} else if (fm_info_get_enet_if(port) ==
 		   PHY_INTERFACE_MODE_SGMII_2500) {
 		/* 2.5G SGMII interface */
-		f_link.phy_id = port;
-		f_link.duplex = 1;
-		f_link.link_speed = 1000;
+		f_link.phy_id = cpu_to_fdt32(port);
+		f_link.duplex = cpu_to_fdt32(1);
+		f_link.link_speed = cpu_to_fdt32(1000);
 		f_link.pause = 0;
 		f_link.asym_pause = 0;
 		/* no PHY for 2.5G SGMII */
@@ -241,9 +241,9 @@  void board_ft_fman_fixup_port(void *fdt, char *compat, phys_addr_t addr,
 	} else if (fm_info_get_enet_if(port) == PHY_INTERFACE_MODE_XGMII &&
 		   port == FM1_10GEC1) {
 		/* XFI interface */
-		f_link.phy_id = port;
-		f_link.duplex = 1;
-		f_link.link_speed = 10000;
+		f_link.phy_id = cpu_to_fdt32(port);
+		f_link.duplex = cpu_to_fdt32(1);
+		f_link.link_speed = cpu_to_fdt32(10000);
 		f_link.pause = 0;
 		f_link.asym_pause = 0;
 		/* no PHY for XFI */