From patchwork Fri Mar 25 05:59:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 601918 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qWXgv6TGlz9sD5 for ; Fri, 25 Mar 2016 16:59:37 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ZHtWCXnp; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=mbLkzy9CPgYBtz+QTpoODbeFxpVM5PCNQVMOvJ2ATuo5cRwLDR /dbtj9KkbD94B7GqCO7syfxIuYyVzi3XPBqv+YEoDUEcoCBv0QeZA3K6oA+WEjcT 8LspMBpmHxoOUnfCSmh2vagOpom7YqYIQ1g9usO+1pzgO0R7BaPioIFjw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=UKsBb+JiyQTt8HOgNjOUY6YdgL4=; b=ZHtWCXnpeQ86O5a5aisl xg+TaQWabKHS8cMd1n3D/rDjMBCgrYD7BzOe6raI9tvmaZESkmgc0yNnUIxfBqDO 5CJFAT3C1B3X2Cy+bPYdB0R4Z2dhX1jK/F/BGlFMy6Mro7iHf3iUMcRy3X/jhgEC ux5o3nAHQoFdCu57sXxhWKI= Received: (qmail 83798 invoked by alias); 25 Mar 2016 05:59:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 83783 invoked by uid 89); 25 Mar 2016 05:59:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Statement, 558, 556, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Mar 2016 05:59:25 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 3D524C01B3C5 for ; Fri, 25 Mar 2016 05:59:24 +0000 (UTC) Received: from reynosa.quesejoda.com (vpn-63-53.rdu2.redhat.com [10.10.63.53]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2P5xMTt002294 for ; Fri, 25 Mar 2016 01:59:23 -0400 To: gcc-patches From: Aldy Hernandez Subject: [committed] fix comment for SSA_PROP_NOT_INTERESTING Message-ID: <56F4D3B9.2070004@redhat.com> Date: Fri, 25 Mar 2016 00:59:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 It's not obvious in the comment at the top of the file that PROP_NOT_INTERESTING may be simulated again. Interestingly enough, Diego's GCC summit presentation on the propagator has much better docs than our internal docs/comments. We should probably merge a lot from there. Anyways... Committed as obvious. I hope nobody cares that I'm improving docs and comments :). Aldy commit a76f8d620455a7edba07e66d37651f4e17cdeff1 Author: Aldy Hernandez Date: Fri Mar 25 00:50:46 2016 -0500 * tree-ssa-propagate.c: Enhance docs for SSA_PROP_NOT_INTERESTING. diff --git a/gcc/tree-ssa-propagate.c b/gcc/tree-ssa-propagate.c index 3277e49..c4535a4 100644 --- a/gcc/tree-ssa-propagate.c +++ b/gcc/tree-ssa-propagate.c @@ -55,6 +55,8 @@ SSA_PROP_NOT_INTERESTING: Statement S produces nothing of interest and does not affect any of the work lists. + The statement may be simulated again if any of its input + operands change in future iterations of the simulator. SSA_PROP_VARYING: The value produced by S cannot be determined at compile time. Further simulation of S is not required.