From patchwork Wed Jul 28 13:36:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 60140 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C8DE7B6ED0 for ; Wed, 28 Jul 2010 23:37:07 +1000 (EST) Received: (qmail 5771 invoked by alias); 28 Jul 2010 13:37:01 -0000 Received: (qmail 5760 invoked by uid 22791); 28 Jul 2010 13:37:00 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, TW_RB, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Jul 2010 13:36:36 +0000 Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id o6SDaYHw023303 for ; Wed, 28 Jul 2010 06:36:34 -0700 Received: from wwe15 (wwe15.prod.google.com [10.241.242.15]) by kpbe15.cbf.corp.google.com with ESMTP id o6SDaWWv026609 for ; Wed, 28 Jul 2010 06:36:33 -0700 Received: by wwe15 with SMTP id 15so1113015wwe.8 for ; Wed, 28 Jul 2010 06:36:32 -0700 (PDT) Received: by 10.216.87.208 with SMTP id y58mr10645703wee.82.1280324192151; Wed, 28 Jul 2010 06:36:32 -0700 (PDT) Received: from coign.google.com (dhcp-172-28-249-136.lul.corp.google.com [172.28.249.136]) by mx.google.com with ESMTPS id h37sm3459881wej.23.2010.07.28.06.36.29 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 28 Jul 2010 06:36:30 -0700 (PDT) From: Ian Lance Taylor To: Richard Henderson Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: [gccgo] Turn on garbage collector References: <4C49C939.7010900@redhat.com> Date: Wed, 28 Jul 2010 06:36:28 -0700 In-Reply-To: <4C49C939.7010900@redhat.com> (Richard Henderson's message of "Fri, 23 Jul 2010 09:54:17 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Richard Henderson writes: > On 07/23/2010 09:51 AM, Ian Lance Taylor wrote: >> +#elif defined(__x86_64__) >> + #ifndef __PIC__ >> + #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp", "rbx") >> + #else >> + #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp") >> + #endif >> +#else > > rbx is not special for x86_64 with or without -fpic. Fixed like so. Thanks. Ian diff -r 53eb98b6170d libgo/runtime/go-go.c --- a/libgo/runtime/go-go.c Mon Jul 26 05:48:18 2010 -0700 +++ b/libgo/runtime/go-go.c Wed Jul 28 06:31:26 2010 -0700 @@ -35,11 +35,7 @@ #define SAVE_REGS asm ("" : : : "esi", "edi") #endif #elif defined(__x86_64__) - #ifndef __PIC__ - #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp", "rbx") - #else - #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp") - #endif + #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp", "rbx") #else #error must define SAVE_REGS #endif