Patchwork [gccgo] Turn on garbage collector

login
register
mail settings
Submitter Ian Taylor
Date July 28, 2010, 1:36 p.m.
Message ID <mcrd3u7ohib.fsf@google.com>
Download mbox | patch
Permalink /patch/60140/
State New
Headers show

Comments

Ian Taylor - July 28, 2010, 1:36 p.m.
Richard Henderson <rth@redhat.com> writes:

> On 07/23/2010 09:51 AM, Ian Lance Taylor wrote:
>> +#elif defined(__x86_64__)
>> + #ifndef __PIC__
>> +  #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp", "rbx")
>> + #else
>> +  #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp")
>> + #endif
>> +#else
>
> rbx is not special for x86_64 with or without -fpic.

Fixed like so.  Thanks.

Ian

Patch

diff -r 53eb98b6170d libgo/runtime/go-go.c
--- a/libgo/runtime/go-go.c	Mon Jul 26 05:48:18 2010 -0700
+++ b/libgo/runtime/go-go.c	Wed Jul 28 06:31:26 2010 -0700
@@ -35,11 +35,7 @@ 
   #define SAVE_REGS asm ("" : : : "esi", "edi")
  #endif
 #elif defined(__x86_64__)
- #ifndef __PIC__
-  #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp", "rbx")
- #else
-  #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp")
- #endif
+ #define SAVE_REGS asm ("" : : : "r12", "r13", "r14", "r15", "rbp", "rbx")
 #else
  #error must define SAVE_REGS
 #endif