diff mbox

slirp: send icmp6 errors when UDP send failed

Message ID 1458604039-10161-1-git-send-email-samuel.thibault@ens-lyon.org
State New
Headers show

Commit Message

Samuel Thibault March 21, 2016, 11:47 p.m. UTC 
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 slirp/udp6.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Thomas Huth March 22, 2016, 3:46 p.m. UTC | #1 
On 22.03.2016 00:47, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
>  slirp/udp6.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/slirp/udp6.c b/slirp/udp6.c
> index 60a91c9..a23026f 100644
> --- a/slirp/udp6.c
> +++ b/slirp/udp6.c
> @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m)
>          m->m_data -= iphlen;
>          *ip = save_ip;
>          DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
> -        /* TODO: ICMPv6 error */
> -        /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/
> +        icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE);
>          goto bad;
>      }
>  

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox

Patch

diff --git a/slirp/udp6.c b/slirp/udp6.c
index 60a91c9..a23026f 100644
--- a/slirp/udp6.c
+++ b/slirp/udp6.c
@@ -113,8 +113,7 @@  void udp6_input(struct mbuf *m)
         m->m_data -= iphlen;
         *ip = save_ip;
         DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
-        /* TODO: ICMPv6 error */
-        /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/
+        icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE);
         goto bad;
     }